Comments (14)
@eps1lon this actually doesn't work because when you construct <input value="0" />
the type of the resulting expression is just JSX.Element<any>
so TypeScript won't actually check the constructor type of the child JSX expression, you can basically put any JSX expression you want inside.
from react.
Yep, that's kind of what I was alluding to in my first response. TypeScript will have no problems with simple interfaces, so the implementing component will just need to wrap it in a
createElement
call. It's an unfortunate limitation :/
@ferdaber , sorry I don't quite understand what does it mean to wrap it in a createElement call
. Could you be so kind to show an example?
Thanks
from react.
this is potentially very useful for us! cc @ferdaber i wonder what problems you and Ryan Florence ran into that prevented him typing children - even if there are problems, we should definitely document them
from react.
Typing children as anything but JSX
is generally safe for TypeScript. It only becomes a problem if you try typing them as specific JSX types.
So if you say "I want my children to be an array of objects with these properties" 👍🏼, but "I want my children to be an array of JSX elements that have this component as their type/constructor" 👎🏼
from react.
In the case above they are just simple interfaces, or objects, so they are able to be well-typed as children.
from react.
ah ok. honestly wouldnt have been a blocker for me adopting ts in Reach UI
from react.
In the case above they are just simple interfaces, or objects, so they are able to be well-typed as children.
Hm, seems I either misunderstood smth or that is not entirely correct. By default (without any explicit typings) typescript blames that child (which is React.Node) can't have any props:
Whatever I do with explicit typing doesn't help eventually.
from react.
Maybe this is an issue with @types/react or that I have React 15.6 installed but not 16.*
from react.
It's honestly a bit difficult for me to decipher what you want to achieve with the short example at the beginning of the issue. Can you elaborate on it?
from react.
Shouldn't this cover most use cases:
interface ParentProps {
children: React.ReactElement<ChildProps>;
}
interface ChildProps {
value: string;
}
function Parent(props: ParentProps) {
return <div>My child has {props.children.props.value} value.</div>
}
// { children: string } is not assignable to ...
<Parent>1</Parent>; // $ExpectError
<Parent><input value="0" /></Parent>;
You could also allow only numbers or arrays. As long as it's assignable to React.ReactNode
you shouldn't have any troubles. Probably helps with safe cloneElement
but I would personally not use this anymore. This pattern creates a tight parent-child coupling that doesn't allow intermediate components (goes against reacts composition model). Context should cover most use cases.
from react.
@eps1lon [...] you can basically put any JSX expression you want inside.
😞 Well at least you could restrict it to primitives? Still has some DX improvements in the parent. For more usage safety you could add a prop-types validator e.g.
Parent.propTypes = {
children: PropTypes.shape({
props: PropTypes.shape({ // could share `propTypes` to the child
value: PropTypes.string.isRequired
})
}).isRequired
};
from react.
Yep, that's kind of what I was alluding to in my first response. TypeScript will have no problems with simple interfaces, so the implementing component will just need to wrap it in a createElement
call. It's an unfortunate limitation :/
from react.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!
from react.
cleaning up old issues - pls reopen if you still face this!
from react.
Related Issues (20)
- [Basic] useReducer: type safe dispatcher call HOT 2
- "Props: One or the Other but not Both" does not work HOT 2
- [Question] QUESTION_TITLE_HERE
- [Advanced] Wrapping/Mirroring a Component with ref forwarding
- facing errors
- not working
- Gene Piki wants to pay 0 USD to have this issue fixed
- JSX.Element is Deprecated HOT 11
- [Bug] The logo text is overflowing in small devices it should be truncate like mobile navigation. HOT 5
- Update CSS So that website can be accessible from any device of any width -- Solved HOT 8
- [Basic] Add resources to basic/recommended/talks.md HOT 3
- [Basic] Want to Fix Navbar Text Issue Without Truncating And Decreased Footer Logo Size Responsively For all Devices HOT 3
- Table of Content HOT 2
- Linked article on defaultProps docs is paywalled HOT 5
- add as a contributor? HOT 7
- [Basic] Linting page links are not working HOT 6
- CLASS METHODS AND CLASS PROPERTIES TITLES INTERCHANGED HOT 3
- [Advanced] ISSUE_TITLE_HERE
- [Advanced] Restrict useage of child component only as a child of a particular component HOT 3
- [Basic] Provide some docs on `memo` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.