Coder Social home page Coder Social logo

Comments (4)

alexbw avatar alexbw commented on June 15, 2024

Good catch, this is because we don't have __ltmetamethod defined internally. I'll add this.

from torch-autograd.

alexbw avatar alexbw commented on June 15, 2024

An update — 
We will not be able to directly support <,<=,>,>=,== operations, because Lua requires that the variables on either side of the comparison have the same type. This will never be true when using autograd, because we wrap all values in objects to keep track of how they're used in the forward pass, to automatically infer the backward pass.

However, we can use our own utilities. So, I added util.le, util.lt, util.ge, util.gt, util.eq so you can make comparisons safely in autograd. See the new LessThan test.

You're also keeping track of values in a dynamically-allocated array. This is the next thing we'll have to tackle, because autograd doesn't support assignment to arrays (autograd requires all method calls be pure functions). I'll make a little utility that could help with that.

from torch-autograd.

alexbw avatar alexbw commented on June 15, 2024

We added support for comparisons, as I mentioned above, and also now support concatenating numbers, using our own autograd.util.cat function. It currently only supports catting variables of the same type (e.g. all FloatTensors or all numbers), and will probably stay that way for awhile, unless specific requests come up.

I modified your example only slightly, so please try this now:

t = require 'torch'
local grad = require 'autograd'
local util = require 'autograd.util'

params = {
   a = t.randn(1,1)
}

f = function(params, x)
   local result = t.sum(x * params.a)

   -- sample from Bernoulli dist
   local bernoulli = {}
   if util.lt(torch.uniform(), t.sum(params.a)) then
         bernoulli[1] = 1
   end

   return t.sum(util.cat(bernoulli) * result)
end

df = grad(f)
x = t.randn(1,1)
print(f(params, x))
print(df(params, x))

By the way, if you want to use optimized mode (autograd(f, {optimize=true})), you will have to pre-generate the random numbers, and put them in the params table. Otherwise, the if statement will be optimized away entirely (we can't overload, and thus can't track, control flow in optimized mode).

from torch-autograd.

alexbw avatar alexbw commented on June 15, 2024

Closing. Reopen if something is wrong.

from torch-autograd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.