Comments (4)
Only a few files involved, I'll take a crack at this. I think .msg should generally be treated as .info in twisted.logger parlance. For logging occurring in error-handling code, I think .error is ok, although an operator might wish to have the option to change .error to .failure if they want to see tracebacks.
from ampoule.
I put together PR #29 for this. It is a pretty short read when/if someone has a moment.
from ampoule.
I should also note that the labels available here in the ampoule repository differ from the twisted repository. Most notably, there is no "review required" label here in ampoule.
from ampoule.
Fixed in #29 .
from ampoule.
Related Issues (20)
- Ampoule serializes job execution HOT 1
- Too hard to associate Ampoule worker IDs with real processes
- sets module deprecated HOT 1
- ProcessPool.callRemote Deferred sometimes fires with None instead of result HOT 1
- ampoule test suite is unreliable, has intermittent failures
- KeyError on worker shutdown sometimes
- ProcessPool spawns more and more processes HOT 1
- test_changeChildReactor fails without installed ampoule
- Twisted warning after ampoule installation HOT 1
- Add a tox to run unit tests on reasonable versions of Python (2.7, 3.5, 3.6) HOT 1
- ProcessPool should take a reactor parameter
- PYTHONPATH is cleared by default rather than preserved HOT 1
- Bootstrap script should be a separate file for compatability with other executables
- Add non-basic usage example.
- don't attempt to "correct" PYTHONPATH configuration for subprocesses unless asked HOT 2
- ampoule doesn't handle childConnectionLost
- switch from travis to github actions
- ampoule twistd plugin uses child class for parent
- Ampoule logging is exceedingly verbose HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ampoule.