Comments (9)
someone-stole-my-name
commented on June 14, 2024
1
Is there any workaround for this bug?
Manually removing the annotations.
from aws-eks-asg-rolling-update-handler.
TwiN
commented on June 14, 2024
1
Just released the fix in v1.8.1
from aws-eks-asg-rolling-update-handler.
zaafar
commented on June 14, 2024
Is there any workaround for this bug?
from aws-eks-asg-rolling-update-handler.
zaafar
commented on June 14, 2024
Just to be clear, that wouldn't redo the EAGER_CORDONING, it will only redo the regular cordoning. Is there any hack/trick to redo the EAGER_CORDONING after this bug?
from aws-eks-asg-rolling-update-handler.
TwiN
commented on June 14, 2024
Seems like this bug was introduced in #42. Versions prior to v1.7.0 didn't have the aws-eks-asg-rolling-update-handler.twin.sh/cordoned-at annotations, and I believe I had specifically avoided adding this annotation just in case something like this would happen.
I'll see if I can do something 🤔
from aws-eks-asg-rolling-update-handler.
TwiN
commented on June 14, 2024
@zaafar @someone-stole-my-name Hey folks, I think #117 fixed this, but I'd appreciate if you could both give it a try.
As soon as https://github.com/TwiN/aws-eks-asg-rolling-update-handler/actions/runs/5172952729 finishes, it should be available with the latest tag (twinproduction/aws-eks-asg-rolling-update-handler:latest)
from aws-eks-asg-rolling-update-handler.
zaafar
commented on June 14, 2024
sure, i am going to test it and get back to you.
from aws-eks-asg-rolling-update-handler.
zaafar
commented on June 14, 2024
looks good to me.
from aws-eks-asg-rolling-update-handler.
zaafar
commented on June 14, 2024
please whenever you get some time, make a release.
from aws-eks-asg-rolling-update-handler.
Related Issues (19)
- Filter out pods from daemon sets when calculating resources
- Ability to roll nodes at a specific time range HOT 1
- There is a potential you won't get all ASGs returned if you have more than 50 ASGs in the account HOT 2
- SetDesiredCapacityInfo lowered the number of nodes in ASG HOT 2
- High Availability (HA) for aws-eks-asg-rolling-update-handler HOT 4
- Panic while upgrading EKS ASGs HOT 4
- deployed the handler successfully, but nothing happens just write staring execution and execution took ... HOT 3
- Ability to bump secondary ASG if primary is full
- Unable to increase ASG desired size: unable to increase ASG HOT 3
- Get ASGs to manage based on tag HOT 1
- 1.4.2 fails to drain nodes HOT 2
- GracePeriod in client.Drain() should be configurable HOT 1
- Unable to terminate instance when desired capacity equals ASG min size
- Handle rolling upgrade when ASG desired capacity has reached max size
- Cordon all outdated nodes before any rolling update action HOT 6
- Occasional deadlock during drain
- Create /health endpoint and report health there instead of panicking
- Handle different hostname label options HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-eks-asg-rolling-update-handler.