Works great with <script> tags but failes with npm package about twilio-video.js HOT 4 CLOSED

I made it work but I had to comment this line https://github.com/twilio/twilio-conversations.js/blob/01bf25157561d64413336b5e776d5af1165e8f6e/lib/client.js#L5 because for some reason require('twilio-common') returns undefined while loading with webpack.

Feedback on this?

from twilio-video.js.

Hi @enahum, and thanks for writing in.

I think what you are seeing is due to the browser override we have in place for twilio-common. It's defined here in package.json and points to src/twilio-common.js. So the line you point out ends up trying to require a browser global (Twilio) that does not exist when you go the Webpack/Browserify route.

We created the browser override for <script> tag users, thinking it would be nice if they could include twilio-common.js and twilio-conversations.js separately. But since then we've decided against it (makes updating harder, doesn't really give the user anything, etc.).

So I think in the next release we will change this: the <script> version of twilio-conversations.js will begin bundling twilio-common.js, and using Webpack/Browserify should "just work".

from twilio-video.js.

Thanks @markandrus so far I forked the project and made the change to that line of code and now it works with webpack.

BTW you should update dependancies and review tests cause two of them were failing for me

from twilio-video.js.

@enahum this should be fixed in 0.13.6. Can you retest? Thanks! (also, integration tests should be a little more robust now)

from twilio-video.js.