add a base64 encoding filter about twig-extensions

[damienalexandre]

👍 for this feature in the core!

[fabpot]

implemented in Twig core (see twigphp/Twig#3102)

[romainneutron]

Probably a binding to this lib is a good way ? https://github.com/alchemy-fr/PHP-dataURI

@nlegoff This is for you

[cryptocompress]

https://github.com/cryptocompress/DataUrlTwigExtension/blob/master/CryptoCompress/TwigBundle/Extension/DataUrlTwigExtension.php

(mime-type detection is missing)

[snc]

for mime-type detection you can check this Symfony2 classes/code:

• MimeTypeTest.php
• FileinfoMimeTypeGuesser.php

[cryptocompress]

you are right. i tested this:
http://pastebin.com/Hi07BaEE

some drawbacks:

• class "MimeTypeGuesser" is a Singleton
• my webhoster disabled Fileinfo ext
• my webhoster disabled "passthru" method
• method "mime_content_type" is deprecated
• there is no posibility to catch the exception (\LogicException SPL?) cleanly (no code)
• in class File\File there is an protected "mime-type => extension" array ($defaultExtensions). with array_flip i might map this...
  BUT:
  in rfc2397 mime-type ([]) is optional. so it works entirely without mime-type or with text/plain... it doesnt matter :)

[romainneutron]

Be carefull, your implementation does not check the string length to comply with RFC 2397 section 2 https://www.ietf.org/rfc/rfc2397.txt

[romainneutron]

Here's my implementation, based on PHP-dataURI

https://github.com/romainneutron/TwigExtension-DataUri

[cryptocompress]

RFC 1866 Hypertext Markup Language - 2.0 November 1995
The `NAMELEN' parameter in the SGML declaration (9.5, "SGML Declaration for HTML") limits the length of an attribute value to 1024 characters.

BC can be overdone :)
and except for mixing datatypes, i like your solution...

👍

[webdevilopers]

👍

[Maelstromeous]

👍

[nateclonch]

👍

[obax]

👍