RSS Pages Blank when run from OS X 10.6 or 10.7 server about tweetledee

[jjschwarz]

Also confirmed this on an OS X box running the latest build of 10.8, which is also PHP 5.3.15

[chrissimpkins]

Thanks for the report Jason.

Issue 1 (userrss.php) : I don't have a Mac OSX server box to test on. Do you mind trying to change the PHP tags from this form:

<?= $variable; ?>

to this form:

<?php echo $variable; ?>

Let's try that as a first step to see if the Mac OSX server doesn't like the short form of the PHP tags for some reason.

Issue 2 (userrss.php - CLI) : This looks like a bug. It is originating from the line 👍

$thequery = $_SERVER['PHP_SELF'] .'?'. urlencode($_SERVER['QUERY_STRING']);

and the query string is not defined when you use it from a terminal. Thanks for pointing this out. I will incorporate this fix into a bug fix release over the weekend.

[chrissimpkins]

Note to self re: Issue 2 Try this fix

if (defined('STDIN')) {
    $thequery = $_SERVER['PHP_SELF'];
}
else {
    $thequery = $_SERVER['PHP_SELF'].'?'.urlencode($_SERVER['QUERY_STRING']);
}

--> ? will eliminate ability to use different queries from the same file in the same RSS reader application because it eliminates the query string from the canonical URL. Could simply add a randomly generated number?

[jjschwarz]

OK, made both changes in userrss.php mentioned above and it fixed the issue. Did you want to file sent back over to you? Are you planning on patching the next version to include these changes in all of the files?

[chrissimpkins]

Excellent, glad to hear that it worked. You are welcome to submit as a pull request and I can merge it in. I will need to update all of the files with these changes so I have a bit of work to do as well.

Thanks much for your help and good luck with it. Let me know if you have any other issues.

[jjschwarz]

Actually I already made all of the changes for you, so I forked the project, uploaded the changes, and did a pull request for all 5 files.

Jason John Schwarz
[email protected]

On Aug 17, 2013, at 2:52 PM, Chris Simpkins [email protected] wrote:

Excellent, glad to hear that it worked. You are welcome to submit as a pull request and I can merge it in. I will need to update all of the files with these changes so I have a bit of work to do as well.

Thanks much for your help and good luck with it. Let me know if you have any other issues.

—
Reply to this email directly or view it on GitHub.

[chrissimpkins]

Fantastic! Thanks much for your help with this. I will merge them in today

[chrissimpkins]

fixes merged into master