Coder Social home page Coder Social logo

Comments (5)

ruhatch avatar ruhatch commented on August 22, 2024

This does indeed apply to case statements as well

from ormolu.

ruhatch avatar ruhatch commented on August 22, 2024

So I've been working through this and it seems the best way to handle this is to extend the SrcSpan from the body to include the last line of the name/pattern part of the match group. This allows us to have multiline patterns, while preserving single line bodies. I will try to get a PR for this in soon.

from ormolu.

mrkkrp avatar mrkkrp commented on August 22, 2024

Re-opened. The PR #116 solves the problem only partially. For example if I have this in a where clause:

   where
-    queryLocated (L mspn _) =
-      case cast mspn :: Maybe SrcSpan of
-        Nothing -> mempty
-        Just (UnhelpfulSpan _) -> mempty
-        Just (RealSrcSpan spn) -> D.singleton spn
+    queryLocated (L mspn _) = case cast mspn :: Maybe SrcSpan of
+      Nothing -> mempty
+      Just (UnhelpfulSpan _) -> mempty

from ormolu.

mrkkrp avatar mrkkrp commented on August 22, 2024

@ruhatch Do you want to make another attempt on this? I think it has relatively high priority right now. If you can't I could pick it up when I have time.

from ormolu.

mrkkrp avatar mrkkrp commented on August 22, 2024

It appears that with the present code it is quite difficult to do the change. We need to re-think the Value module and find a way to make it manageable and easier to understand.

from ormolu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.