Comments (5)
This does indeed apply to case
statements as well
from ormolu.
So I've been working through this and it seems the best way to handle this is to extend the SrcSpan
from the body to include the last line of the name/pattern part of the match group. This allows us to have multiline patterns, while preserving single line bodies. I will try to get a PR for this in soon.
from ormolu.
Re-opened. The PR #116 solves the problem only partially. For example if I have this in a where clause:
where
- queryLocated (L mspn _) =
- case cast mspn :: Maybe SrcSpan of
- Nothing -> mempty
- Just (UnhelpfulSpan _) -> mempty
- Just (RealSrcSpan spn) -> D.singleton spn
+ queryLocated (L mspn _) = case cast mspn :: Maybe SrcSpan of
+ Nothing -> mempty
+ Just (UnhelpfulSpan _) -> mempty
from ormolu.
@ruhatch Do you want to make another attempt on this? I think it has relatively high priority right now. If you can't I could pick it up when I have time.
from ormolu.
It appears that with the present code it is quite difficult to do the change. We need to re-think the Value
module and find a way to make it manageable and easier to understand.
from ormolu.
Related Issues (20)
- Interesting comment placements in various scenarios HOT 1
- Idempotency check fails for comment in import list
- Format existential data types better HOT 1
- Overloaded labels (hash) syntax gets formatted with space after hash sign HOT 2
- Support for literate Haskell HOT 3
- Formatting {-# LANGUAGE #-} repeats previous comments like vim modelines HOT 1
- Add `-R, --recursive` option for implying `--mode inplace ` and all `*.hs` file under given directory HOT 2
- Language pragma `JavaScriptFFI` can't be parsed
- Formatted file has invalid syntax for the associated type synonym defaults HOT 2
- Format selection containing `->` HOT 1
- Ormolu.Fixity doesn't compile HOT 3
- Support “fine-grained” operator precedence
- Extra indentation for hanging `\case` statements with `(&)` HOT 1
- Ormolu incorrectly inserts parentheses around type-level multiplication HOT 4
- Consider supporting fixity namespacing HOT 1
- Compact single-line expression with dangling close paren HOT 2
- Make it clear that configuration files must end with a newline HOT 1
- Support a `--compatible` flag HOT 6
- Provide a way to determine which version of ormolu is formatting a document? HOT 1
- Format multiple files in parallel HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ormolu.