Coder Social home page Coder Social logo

Comments (14)

azolotov avatar azolotov commented on April 16, 2024

I agree

from bootstrap.

tjcrowder avatar tjcrowder commented on April 16, 2024

Agreed. Even the white-on-green alert is difficult. Seems to me both were much more readable last week, so this may be a regression.

from bootstrap.

optikfluffel avatar optikfluffel commented on April 16, 2024

just sent a pull request

from bootstrap.

sankage avatar sankage commented on April 16, 2024

My proposal is to change the yellow to orange, however @orange with the existing gradient scheme seems too light, so I am using #ff7d00 and lowering the lightening of its dark-end by 5%

&.warning {
  #gradient > .vertical(lighten(#ff7d00, 25%), lighten(#ff7d00, 5%));
  border-bottom-color: #ff7d00;
}

orange alert

update The border color of my previews is still using the old @yellow, whoops.

from bootstrap.

tjcrowder avatar tjcrowder commented on April 16, 2024

@sankage: Certainly much better (and I prefer orange anyway), but all four of them remain a bit hard to read.

from bootstrap.

sankage avatar sankage commented on April 16, 2024

@tjcrowder: Orange + @optikfluffel's font-color change

orange+contrast

from bootstrap.

tjcrowder avatar tjcrowder commented on April 16, 2024

@sankage: (It happens this is a very good time for me to be testing this, it's the end of the day and my eyes get a bit...picky...round about now.) To me the blue and green look great, the orange looks pretty good, and the red wants the white back. :-)

from bootstrap.

sankage avatar sankage commented on April 16, 2024

After looking at my orange, I feel that the orange starts to take importance away from the red. I actually like yellow with contrast more.

contrasted alert

from bootstrap.

tjcrowder avatar tjcrowder commented on April 16, 2024

@sankage: You're right, the yellow is better. All look good (to these particular old/tired eyes on this particular monitor, YMMV) except the red, which I find hard to read. If the font on the red were black rather than grey, it might be okay (for me). (I really love the tone of the colors, btw.)

FWIW, I don't see any issue with white on red but black/grey on all the others. Errors are special.

from bootstrap.

philjohn avatar philjohn commented on April 16, 2024

Agree, white on red would be better. Think about an alert you probably see almost everyday - the common stop sign, white on red.

from bootstrap.

optikfluffel avatar optikfluffel commented on April 16, 2024

ok got me with the stop-sign :D
like this?
basic alerts with the error-font white

from bootstrap.

tjcrowder avatar tjcrowder commented on April 16, 2024

@optikfluffel: Looks great to me, FWIW.

from bootstrap.

jamesweiner avatar jamesweiner commented on April 16, 2024

Looking much better! Great stuff.

from bootstrap.

mdo avatar mdo commented on April 16, 2024

Going to close this thread and punt discussion over to the duplicate issue: #69.

We'll have new alerts sooner than expected with the next release, 1.1.2, with more contrast and tighter spacing.

from bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.