Comments (4)
In principle, I don't have anything against also applying the regular .disabled
styling to cases where aria-disabled="true"
is set.
Of course, you can achieve this currently by manually adding the .disabled
class (like you would with "faked" buttons that use <a>
, for instance)
<button type="button" class="btn btn-primary disabled" aria-disabled="true"> … </button>
If we go with these styles being applied out-of-the-box directly based on the aria-disabled
attribute, we can then tweak the explanation in https://getbootstrap.com/docs/5.3/components/buttons/#disabled-state about authors needing to add .disabled
themselves.
If we don't want to go with this, we can at least expand the explanation in https://getbootstrap.com/docs/5.3/components/buttons/#disabled-state to mention that the same caveat about adding .disabled
to links also needs to be done for buttons that aren't really disabled
from bootstrap.
Thanks for this suggestion @coliff.
Edit: Your StackBlitz link seems to be broken, could you please update it if possible?
If I understand the content correctly, we're talking here simply to ensure some visual consistency so that disabled
or aria-disabled="true"
applied on a button would have the same rendering. My first feeling would be that it could work even if we would need to double-check some edge cases.
@patrickhlauke would it make sense to you to have such a defensive CSS approach or would it be necessary on the contrary to have a different rendering?
from bootstrap.
Could you @coliff or @julien-deramond tell me, in which section of Bootstrap should i find the actual issue in real time, I opend Bootstrap many times but I couldn't find it.
I want to fix it. My humble request please give me some hints....
Though I am newbie in contribution I am going anywhere whithout solve it.
from bootstrap.
Thanks @AgentKaash but this is not yet decided whether we're going to make this modification or not. So there's no PR to provide at the moment.
in which section of Bootstrap should i find the actual issue in real time, I opend Bootstrap many times but I couldn't find it
It's not in the documentation. This would be a defensive CSS approach for this use case.
from bootstrap.
Related Issues (20)
- Modal of Bootstrap v5.3 did not work! HOT 1
- How RTL support works with Sass in Bootstrap.
- The dropdown is not working after updating navbar content using HTMX
- Define `$component-active-color` with `color-contrast()` HOT 1
- Active nav links with default style look inactive HOT 2
- Request for recovery of One Time Key
- docs: Improve install guide for modern use like in scss.
- Reduce CSS variable overrides for colors HOT 1
- Add a glass effect to dropdowns HOT 3
- Floating labels incorrectly positioned for inputs with autofill, but no value HOT 2
- Upon initial launch of the Bootstrap modal NVDA reads all the content of the modal
- System UI font not used on WebKit
- bootstrap
- Carousel More Gallery HOT 1
- Offcanvas - dispose() not reseting scrollbars
- overflow-x-scroll has an !important applied negating respinsive directives HOT 1
- [Docs] Colour modes for individual elements
- Suggest incorporating a customizable theming feature into Bootstrap to address the issue of similar-looking designs HOT 1
- Float-start/end are mistakenly flipped on RTL CSS with LTR dir HOT 1
- SASS compiling
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap.