Coder Social home page Coder Social logo

Comments (15)

Pewpewarrows avatar Pewpewarrows commented on April 27, 2024

I'd love to see this as a Compass plugin that I can just pull-in to any project.

from bootstrap-sass.

brentkirby avatar brentkirby commented on April 27, 2024

Does anyone really even use sass gems without either compass or rails? (or both) I'd imagine anyone using a sass library in a "standalone" environment is probably using compass but maybe not?

I don't see why starting out with rails and compass support (separately or together if your using both) is a problem. If Rails is loaded, load the engine. Include files etc for compass so it can function as a compass extension when working in a non-rails environment. I'd imagine the gemspec wouldn't require either of them except maybe as development dependencies (if you wanted to contribute writing helpers and such). Should probably add a test framework for development as well. I'd just use rspec unless anyone else objects to that :) Using minitest/testunit is fine too, or i guess technically we could run both.

from bootstrap-sass.

oskarrough avatar oskarrough commented on April 27, 2024

It would be fair to make the port of Bootstrap to sass rely on Compass, seing as almost every sass user is using it.

@brentkirby, it's not a problem per se, but Bootstrap as is, is a front-end toolkit and not dependent on any other framework. Having said that, I don't even know what gemspec is. Just not sure I see why Bootstrap should be mixed with with anything else but sass.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

@brentkirby Yeah, we'll make boostrap-sass either a rails/compass library, depending on which one we can load.

I'll hold off pushing any of the Rails-specific stuff until we have conditional loading nailed down, want to make a start? I still have exams until this time next week so I can't commit to too much input this side of them.

from bootstrap-sass.

brentkirby avatar brentkirby commented on April 27, 2024

sure. just forked it. Is everything up to date on the 2.0 branch?

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

I think this is the set of changes.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

@brentkirby We have a week before Bootstrap 2.0 is released. My exams also finish tomorrow afternoon, so I've got a couple of days to hack on bootstrap-sass, but I don't want to duplicate any of your work if you have some stuff to push up and merge in. If you don't, I'll just plough on with this ticket tomorrow.

from bootstrap-sass.

oskarrough avatar oskarrough commented on April 27, 2024

Wouldn't it make it a lot easier for us if we waited with the conversion until their testing and feedback have ended?

from bootstrap-sass.

nhance avatar nhance commented on April 27, 2024

Is there a branch with some work in progress on this? I'd love to finish this up so we can start using this in an internal project.

from bootstrap-sass.

allaire avatar allaire commented on April 27, 2024

Bootstrap 2 is coming out tonight, did you guys we'll have a working version soon of the 2.0? What did you do finally, went rails or sass only?

from bootstrap-sass.

sevenseacat avatar sevenseacat commented on April 27, 2024

A lot of sass users aren't using compass, where did that idea come from? :/ Please don't make it rely on compass!

from bootstrap-sass.

oskarrough avatar oskarrough commented on April 27, 2024

Using Compass with Sass is a huge advantage but I'm fine keeping the port more one-to-one, converting the Less mixins Bootstrap has.

from bootstrap-sass.

sevenseacat avatar sevenseacat commented on April 27, 2024

Is a huge advantage if you like and use compass, yeah.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

The 2.0 branch now has support for either the Rails asset pipeline or Compass. I'm currently looking at what changes will be needed for an Rails application that also uses Compass, just looks like I'll need to set a couple of configuration variables.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

Consider this complete.

from bootstrap-sass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.