Coder Social home page Coder Social logo

Comments (18)

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

Cheers man, I'll change it to be identical to the less line. Probably me trying to be clever when I was converting the code.

Sorry about not getting back to you on this one, exams in January are slowly drowning me already.

from bootstrap-sass.

bbenezech avatar bbenezech commented on April 27, 2024

Arf, no problem. I wasn't sure what was causing it anyway.
Can you bump a release soonish?

Thanks Thomas!

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

Aye, I'm hoping to get a release tonight that addresses all the current issues.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

I think I've got this fixed now.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

sigh thinking about it, this could either be the lack of quotes causing the issue, or the use of shorthand colours.

Let me know if the 1.4.1 release has fixed it, if it's the shorthand colours I'll run round and change them and push 1.4.2.

from bootstrap-sass.

bbenezech avatar bbenezech commented on April 27, 2024

Not yet:

http://ipinfo.info/netrenderer/index.php w/
http://rails-admin-tb.herokuapp.com/admin/comments/new

Sorry!

from bootstrap-sass.

bbenezech avatar bbenezech commented on April 27, 2024

Sup, bro.

I want the MSDN compliance Gold® Logo on RailsAdmin's homepage, it would enlarge my penis very much.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

Give me an hour, go go go go go.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

filter doesn't support the use of named colours, only took me an hour to work it out. fun times. Guess I also have to figure out what's happening to the topbar as well but that's slightly less breaking than those buttons.

Will try and push a new release with the fixes later today.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

That should do the trick, according to my Heroku sample application.

Let me know though, I probably won't be able to push any more changes for the next few days (interview at Oxford) but, like I say, there shouldn't be a problem.

from bootstrap-sass.

bbenezech avatar bbenezech commented on April 27, 2024

The buttons now look fine, but the toolbar's still broken. (I updated RA demo with 1.4.2 so you can have a look)
Steve Ballmer said I can't have the badge. Bummer.

from bootstrap-sass.

rwjblue avatar rwjblue commented on April 27, 2024

Looks like the issue is with sass using the smallest representation for a given color, but IE needs the full value. Per the (Sass reference material)[http://sass-lang.com/docs/yardoc/file.SASS_REFERENCE.html]:

"Compressed style takes up the minimum amount of space possible, having no whitespace except that necessary to separate selectors and a newline at the end of the file. It also includes some other minor compressions, such as choosing the smallest representation for colors. It’s not meant to be human-readable."

from bootstrap-sass.

rwjblue avatar rwjblue commented on April 27, 2024

I am going to look into the SASS compile options to see if there is anything that can be specified inline to prevent #222222 from being abbreviated to #222, but as a quick fix we included the following inline style in the head section of our layout:

<style type="text/css">
  .topbar-fix {
    filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#333333', endColorstr='#222222', GradientType=0) !important
  }
</style>

Then include the topbar-fix class where needed, this class will then override the incorrect filter that SASS compiled.

It fixes the issue with the topbar gradient in IE 7/8.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

Yeah, that was the problem I was having with the buttons, SASS will use a named colour representation or a shorthand notation if it can which MS-gradient won't accept.

The solution I had was to knock the blue value down a notch, which has next to no impact on the colour but makes it work. There doesn't seem to be no way of configuring what the default 'format' of the output is, which means we have to make the output in such a way that it can't be shorthanded, or to override it as you are doing. It's evil, but at the same time I see no obvious way around it.

from bootstrap-sass.

rwjblue avatar rwjblue commented on April 27, 2024

I found a blog article that may be able to work as a solution:

http://pinds.com/2011/11/30/fixing-ie-gradients-with-rails-3-1-and-scss/

This might make it possible to fix inside of bootstrap-sass itself. I'll try to incorporate offline and see if it works...

from bootstrap-sass.

bbenezech avatar bbenezech commented on April 27, 2024

Cross posted there: sass/sass#231

Thanks @rjackson for the investigation.

from bootstrap-sass.

thomas-mcdonald avatar thomas-mcdonald commented on April 27, 2024

Consider this fixed. Finally.

from bootstrap-sass.

bbenezech avatar bbenezech commented on April 27, 2024

Let's party. 🍰 🍸

from bootstrap-sass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.