Coder Social home page Coder Social logo

migration error about libsql HOT 7 CLOSED

kelbyfaessler avatar kelbyfaessler commented on June 26, 2024
migration error

from libsql.

Comments (7)

kelbyfaessler avatar kelbyfaessler commented on June 26, 2024 1

closing the issue since its a drizzle issue with their generated sql

from libsql.

haaawk avatar haaawk commented on June 26, 2024

Thank you for bringing up the issue @kelbyfaessler . Would you have a code / SQL that reproduces the issue?

from libsql.

kelbyfaessler avatar kelbyfaessler commented on June 26, 2024

I played around with the generated SQL and figured out the issue.

The issue is in this part of a table definition

CREATE TABLE `mytable` (
    ...
    `created_at` text DEFAULT strftime('%Y-%m-%dT%H:%M:%fZ', 'now') NOT NULL,
    ...
);

If I put parens around the strftime call, then it works

`created_at` text DEFAULT (strftime('%Y-%m-%dT%H:%M:%fZ', 'now')) NOT NULL,

from libsql.

AndriiSherman avatar AndriiSherman commented on June 26, 2024

@kelbyfaessler сan you show the drizzle schema you are using?

from libsql.

kelbyfaessler avatar kelbyfaessler commented on June 26, 2024

@AndriiSherman the line in the schema looks like this:

    createdAt: text("created_at").notNull().default(sql`strftime('%Y-%m-%dT%H:%M:%fZ', 'now')`),

which means its not a drizzle issue and rather issue with my own code, right? Since I could insert the parens like so

    createdAt: text("created_at").notNull().default(sql`(strftime('%Y-%m-%dT%H:%M:%fZ', 'now'))`),

from libsql.

haaawk avatar haaawk commented on June 26, 2024

According to my understanding you're right @kelbyfaessler. This is an issue with the code not drizzle itself but @AndriiSherman will know better.

from libsql.

AndriiSherman avatar AndriiSherman commented on June 26, 2024

Author

Yes, so the case here is that if you are using the sql template in the drizzle schema, we can't know exactly what is there because it can be basically anything. It's done to not block you from using anything you need while we are implementing first-class support for a specific feature. So it means anything that is in the sql template will be added after the default as-is, so it is your responsibility to put the right code there, same as you would put in raw sql DDL statement after DEFAULT

from libsql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.