Comments (4)
Hi @JaimeRZP, I think this is a historical issue - the AHMC.sample
function predates the AbstractMCMC
package. We can now depreciate the AHMC.sample
function and remove it in future releases. We can promote the AbstractMCMC.sample
API more so users can switch to this interface.
from advancedhmc.jl.
Ok that's interesting. I was proposing to get rid of both but keep the instance of AbstractMCMC.sample
seems reasonable to me. One thing that I am doing in #325 is to change the signature of AbstractMCMC.sample
from:
function AbstractMCMC.sample(
model::LogDensityModel,
kernel::AbstractMCMCKernel,
metric::AbstractMetric,
adaptor::AbstractAdaptor,
N::Integer;
kwargs...,
)
to
function AbstractMCMC.sample(
model::LogDensityModel,
sampler::AbstractHMCSampler,
N::Integer;
kwargs...,
)
where AbstractHMCSampler
is the umbrella type of all new constructors.
from advancedhmc.jl.
Do we still need this function after #325? It feels a bit redundant to me. Maybe we can depreciate it?
from advancedhmc.jl.
I think even though #325 is now merged.
Having this function here is probably still useful if users want to use the AbstractMCMC interface without loading Turing.
However, I would remove AHMC.Sample.
from advancedhmc.jl.
Related Issues (20)
- README example fails HOT 3
- Step size initialization uses GLOBAL RNG instead of reproducible RNG from caller
- Forecasting
- Feature request: HMC sampling from convex polytopes defined by linear programs
- Add nuts-rs's metric adaptation HOT 15
- More friendly default `sample` interface HOT 9
- Make `HMCState` stores `rng` in `AbstractMCMC` interface. HOT 5
- Weighted Log Likelihood #featurerequest
- Convinience Constructors HOT 16
- Objects of type LogTargetDensity are not callable HOT 2
- Retest is broken HOT 2
- Moving ReadMe to Docs
- Component Arrays with DenseEuclideanMetric fails HOT 1
- Doc string error for NUTS HOT 2
- `AbstractMCMC.step` interface broken HOT 3
- Define a model HOT 1
- In sample progress=true prints more than a progress-bar HOT 1
- Accessing samples?
- Progress message `ratio_divergent_transitions_during_adaption` bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from advancedhmc.jl.