Coder Social home page Coder Social logo

Kubernetes Cluster "OS and Data Disks Encrypted with CMK" and "Temp Disks and Cache Not Encrypted.md" False Positive about steampipe-mod-azure-compliance HOT 7 CLOSED

turbot avatar turbot commented on May 29, 2024
Kubernetes Cluster "OS and Data Disks Encrypted with CMK" and "Temp Disks and Cache Not Encrypted.md" False Positive

from steampipe-mod-azure-compliance.

Comments (7)

misraved avatar misraved commented on May 29, 2024

Thanks @fgomesz for raising this issue and providing good context on how the control should work.

We will pick this up shortly and hopefully fix and release it 👍 .

from steampipe-mod-azure-compliance.

github-actions avatar github-actions commented on May 29, 2024

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

from steampipe-mod-azure-compliance.

github-actions avatar github-actions commented on May 29, 2024

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

from steampipe-mod-azure-compliance.

github-actions avatar github-actions commented on May 29, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from steampipe-mod-azure-compliance.

cbruno10 avatar cbruno10 commented on May 29, 2024

@bigdatasourav Is this something we can fix in the plugin, so the azure_kubernetes_cluster table can return the correct disk encryption information even if Steampipe is not whitelisted?

Else, are we able to detect if we're getting a response as if we're not whitelisted, so we can return the correct result in the query?

from steampipe-mod-azure-compliance.

bigdatasourav avatar bigdatasourav commented on May 29, 2024

@cbruno10 @fgomesz In our tests, we get the disk encryption information even if Steampipe is not whitelisted.

Below are the steps we have followed to reproduce the above issue with the latest plugin and compliance version-

  1. Created a cluster name test-cmk1 with disk-encryption-set and without enforcing the IP whitelist -
image image
> select name, disk_encryption_set_id from azure_kubernetes_cluster where name = 'test-cmk1'
+-----------+--------------------------------------------------------------------------------------------------------------------------------------+
| name      | disk_encryption_set_id                                                                                                               |
+-----------+--------------------------------------------------------------------------------------------------------------------------------------+
| test-cmk1 | /subscriptions/d46d7416-f95f-4771-454354354/resourceGroups/demo/providers/Microsoft.Compute/diskEncryptionSets/test-cmk-disk |
+-----------+--------------------------------------------------------------------------------------------------------------------------------------+

Control output - (expected)

➜  steampipe-mod-azure-compliance git:(main) steampipe query azure_compliance.query.kubernetes_cluster_os_and_data_disks_encrypted_with_cmk
+---------------------------------------------------------------------------------------------------------------------------------------------+--------+------------------------------------------------------+----------------+-----------------+
| resource                                                                                                                                    | status | reason                                               | resource_group | subscription    |
+---------------------------------------------------------------------------------------------------------------------------------------------+--------+------------------------------------------------------+----------------+-----------------+
| /subscriptions/d46d7416-f95f-4771-454354354/resourcegroups/demo/providers/Microsoft.ContainerService/managedClusters/test-cmk1      | ok     | test-cmk1 os and data diska encrypted with CMK.      | demo           | new AAA |
  1. Created a cluster name test-whitelist with disk-encryption-set and enforced the IP whitelist - (Steampipe is not whitelisted)
image image
> select name, disk_encryption_set_id from azure_kubernetes_cluster where name = 'test-whitelist'
+----------------+--------------------------------------------------------------------------------------------------------------------------------------+
| name           | disk_encryption_set_id                                                                                                               |
+----------------+--------------------------------------------------------------------------------------------------------------------------------------+
| test-whitelist | /subscriptions/d46d7416-f95f-471-bbb5-529d4c769c/resourceGroups/demo/providers/Microsoft.Compute/diskEncryptionSets/test-cmk-disk |
+----------------+--------------------------------------------------------------------------------------------------------------------------------------+

Control output - (expected)

➜  steampipe-mod-azure-compliance git:(main) steampipe query azure_compliance.query.kubernetes_cluster_os_and_data_disks_encrypted_with_cmk
+---------------------------------------------------------------------------------------------------------------------------------------------+--------+------------------------------------------------------+----------------+-----------------+
| resource                                                                                                                                    | status | reason                                               | resource_group | subscription    |
+---------------------------------------------------------------------------------------------------------------------------------------------+--------+------------------------------------------------------+----------------+-----------------+
| /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/demo/providers/Microsoft.ContainerService/managedClusters/test-whitelist | ok     | test-whitelist os and data diska encrypted with CMK. | demo           | newwarriors AAA |
+---------------------------------------------------------------------------------------------------------------------------------------------+--------+-----------------------------------

Please let us know if we miss anything.

from steampipe-mod-azure-compliance.

bigdatasourav avatar bigdatasourav commented on May 29, 2024

Hey @fgomesz, We are closing this issue because we have not heard from you. Please feel free to reopen the issue if you want to share or discuss anything.

from steampipe-mod-azure-compliance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.