Comments (7)
Interesting, I must admit I didn't test this on API 25 but on API 28. Perhaps it has some issues with calculating fitsSystemWindows insets. I'll try to find what's wrong.
from dawn.
I did not manage to reproduce this entirely here. Initially everything looked correctly and these buttons were above navigation bar, but that broke when rotating device. I've pushed additional commit that fixes this to a separate branch here: 552f89d
I have found another bug. Not sure how to fix that:
The status bar is now partially visible. I was using
WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS
so that the translucent bar also gets removed.
Personally I found this to be a good side effect 😁. It improves readability of status bar icons, which can be always hidden by entering full-screen mode when needed. But I removed that flag because it was breaking fitsSystemWindows insets.
from dawn.
I'm on API 27 but my phone has hw buttons and I can't test this on the emulator since is so damn slow to even try to use it.
from dawn.
I have found another bug. Not sure how to fix that:
Whoops. I don't think this can be fixed letting the layout extend behind the status bar. The dark gradient has to start from the bottom.
Personally I found this to be a good side effect 😁. It improves readability of status bar icons,
I see where you're coming from, but I wanted to give the content image/video a higher priority than the status bar icons in the media viewer screen.
We could… dim the status bar so that the icons don't interfere with the media.
from dawn.
@Esselans the emulator has become quite fast now. What are your computer specs?
from dawn.
@saket i5 4210, 8gb ram (w10 w/ ssd disk). The emulator takes 10 minutes to start and then it has like a 1.5 - 2 seconds lag.
from dawn.
@Esselans that does not sound too bad. Make sure you have hardware acceleration enabled (Intel HAXM) and you're using an x86 image for your emulator. It takes a few seconds on my machine to start.
from dawn.
Related Issues (20)
- Tor & Moderation tools HOT 2
- libreddit support? HOT 3
- Mark posts as read after viewing
- Invalid indexed media file
- Multiselection in subreddit list edit mode
- Cache subreddit submission list in room
- Add media type in submission byline
- Adding a hide feature HOT 1
- Is the project abandoned? HOT 3
- Missing new comment FAB HOT 5
- Cannot open Reddit links directly in Dawn
- Missing white theme
- Repeatedly tapping on images raises the Share/Download/etc. buttons off the screen.
- multi factor authentication causes account issues
- Go to default subreddit on back button pressed
- Support for iOS HOT 1
- Set Default Homepage to view recent feeds
- Switch accounts by simple press rather than swipe
- Add method for removing vote HOT 4
- The end of Dawn for Reddit
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dawn.