All and Any methods don't work correctly with null values about shaolinq

[samcook]

Also affects Any with !=

this.Model.DbObjects.Any(x => x.Foo != "hello").ShouldBe(true);
// actually returns false

SELECT
    (
        SELECT CASE
                   WHEN ((EXISTS
                          (
                              SELECT "T0"."DbObjectId",
                                     "T0"."Foo"
                              FROM "DbObject" AS "T0"
                              WHERE (("T0"."Foo") <> ('hello'))
                          )
                         )
                        ) THEN
            (1)
                   ELSE
            (0)
               END AS "EXISTS_COL"
    ) AS "value";

[samcook]

For reference, this is what EntityFramework 6 generates:

db.DbObjects.All(x => x.Foo == "hello"); // returns false

SELECT CASE
           WHEN (NOT EXISTS
                     (
                         SELECT 1 AS [C1]
                         FROM [dbo].[DbObjects] AS [Extent1]
                         WHERE (NOT (
                                        (N'hello' = [Extent1].[Foo])
                                        AND ([Extent1].[Foo] IS NOT NULL)
                                    )
                               )
                               OR (CASE
                                       WHEN (N'hello' = [Extent1].[Foo]) THEN
                                           CAST(1 AS BIT)
                                       WHEN (NOT (
                                                     (N'hello' = [Extent1].[Foo])
                                                     AND ([Extent1].[Foo] IS NOT NULL)
                                                 )
                                            ) THEN
                                           CAST(0 AS BIT)
                                   END IS NULL
                                  )
                     )
                ) THEN
               CAST(1 AS BIT)
           ELSE
               CAST(0 AS BIT)
       END AS [C1]
FROM
(SELECT 1 AS X) AS [SingleRowTable1];

db.DbObjects.Any(x => x.Foo != "hello"); // returns true

SELECT CASE
           WHEN (EXISTS
                 (
                     SELECT 1 AS [C1]
                     FROM [dbo].[DbObjects] AS [Extent1]
                     WHERE NOT (
                                   (N'hello' = [Extent1].[Foo])
                                   AND ([Extent1].[Foo] IS NOT NULL)
                               )
                 )
                ) THEN
               CAST(1 AS BIT)
           ELSE
               CAST(0 AS BIT)
       END AS [C1]
FROM
(SELECT 1 AS X) AS [SingleRowTable1];

[tumtumtum]

Could you add a unit test?

[samcook]

Will do

[samcook]

Unsurprisingly, the same issue can also apply to the predicates for Where, Count, etc...

[tumtumtum]

TLDR but is this is an issue with SQL server only or all providers?

[samcook]

Affects both SQL server and sqlite, haven't tried mysql or postgres

[tumtumtum]

Yeah comparing with null is undefined so not(undefined) isn't true.

I have to have a think about where else this affects could affect the framework because LINQ semantics for NULL is different.