sidecar container inject failed on kubernetes 1.14.3 about k8s-sidecar-injector

[byxorna]

Hey @like-inspur - looks like the injector decided that the annotation required is injector.tumblr.com/request.

From your logs:

I0521 06:20:35.624673       1 webhook.go:165] Pod monitoring/consul-0 annotation **injector.tumblr.com/request is missing**, skipping injection

https://github.com/tumblr/k8s-sidecar-injector/blob/master/cmd/main.go#L63 looks like you can pass the --annotation-namespace argument to the service at boot to change that.

[like-inspur]

I have config env ANNOTATION_NAMESPACE as injector.inspur.com in k8s-sidecar-injector deployment and work fine with 0.1.8 version, but work failed with 0.4.0

[byxorna]

I have config env ANNOTATION_NAMESPACE as injector.inspur.com in k8s-sidecar-injector deployment and work fine with 0.1.8 version, but work failed with 0.4.0

Interesting - I did a quick grep back through the 0.1.8 release (and HEAD) and cannot find anywhere we are pulling the ANNOTATION_NAMESPACE out of the environment. This is very curious that it was working for you before!

The fix here would be to pass --annotation-namespace=injector.inspur.com to the entrypoint script. Sorry about that odd behavior! If you would like to submit a PR to handle ANNOTATION_NAMESPACE in entrypoint.sh, it would be much appreciated!

[like-inspur]

sorry， I forget I have modify dockerfile on 0.1.8 like you previously mentioned, I'd like to create pull request for this

[byxorna]

Fixed via #31. The docker image in tumblr/k8s-sidecar-injector:latest will respect ANNOTATION_NAMESPACE env var now :)

Thanks for reporting this!