add led on/off while midi send note about control-surface

[tttapa]

The MIDI controller doesn't support this, but you can use the Control Surface library.

Be sure to use the revision-4 branch until further notice.
It's not finished yet, but it should compile and work.

https://github.com/tttapa/Control-Surface/blob/revision-4/examples/MIDIOutput/PushButtonsLEDs/PushButtonsLEDs.ino

[pandeagus]

IM SORRY IM ASKING YOU AGAIN..
I GET ERROR WHEN COMPILE THIS CODE

[pandeagus]

Sorry
after I enter several libraries from the adafruit error the compile is gone. i try code from you but the leds still don't turn on. did I make a mistake? I've led the series to ground.

[tttapa]

I'm sorry about the error, I have to remove the Adafruit depenencies when I do an official release.

The LED relies on the software on the other side to turn it on or off. For example, if you have a DJ or digital audio workstation on your computer, the LED will also turn on if you click the button on your computer.

What software are you using?

[pandeagus]

I use amplitube and bias fx.. i just want make midi foot controller for that software.. thank very much for your help.. Pada tanggal Rab, 23 Jan 2019 20.35, tttapa <[email protected]> menulis:

…

I'm sorry about the error, I have to remove the Adafruit depenencies when I do an official release. The LED relies on the software on the other side to turn it on or off. For example, if you have a DJ or digital audio workstation on your computer, the LED will also turn on if you click the button on your computer. What software are you using? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/tttapa/MIDI_controller/issues/74#issuecomment-456785498>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AsuHoIqcyxqPYFWeb9u__i741cofNlFCks5vGFb0gaJpZM4aK4Z0> .

[tttapa]

Sadly, Amplitube doesn't support MIDI feedback. (source)
This means that the Arduino can never know the state of the effects.
The only thing you can do is keep the state on the Arduino, but if you enable the effect using your computer, or when it was already on when you plugged in the Arduino, the LED will always be wrong.

If you want the LED to work correctly, you'll have to wait for Amplitube to fully support MIDI controllers, or use different software.

[tttapa]

I updated the Control Surface library, there's now an example that shows how to keep the states of the LEDs on the Arduino only.

It compiles successfully on Arduino 1.8.5, but I haven't tested it yet.

https://github.com/tttapa/Control-Surface/blob/master/examples/MIDIOutput/PushButtonsLEDsNoMIDIFeedback/PushButtonsLEDsNoMIDIFeedback.ino

[pandeagus]

Hm.. thanks you very much for your help... bu can ask you again.. how can one button when press.. can MIDI SEND NOTE and MIDI SEND CONTRO CHANGE together.. with your library function.. i send the screenshot result of midi ox.. i ask this because if can SEND MIDI NOTE and MIDI CONTROL CHANGE together .. Bias fx software can be control.. i dont Know why if just sending MIDI Control Cange cant respon on bias fx software.. and if just send MIDI send note still cant respon on bias fx software but if sending together MIDI NOTE and MIDI CONTROL CHANGE can control that Software. I'm sorry for interrupting your time. and if possible, may I know your real name ? one againt thank you very much for your help.. Pada tanggal 24 Jan 2019 1.57 AM, "tttapa" <[email protected]> menulis: Sadly, Amplitube doesn't support MIDI feedback. (source <https://cgi.ikmultimedia.com/ikforum/viewtopic.php?f=5&t=16741>) This means that the Arduino can never know the state of the effects. The only thing you can do is keep the state on the Arduino, but if you enable the effect using your computer, or when it was already on when you plugged in the Arduino, the LED will *always* be wrong. If you want the LED to work correctly, you'll have to wait for Amplitube to fully support MIDI controllers, or use different software. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/tttapa/MIDI_controller/issues/74#issuecomment-456903113>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AsuHoFRL1J6i0bqPJyUSor07gzHnrwqJks5vGKKmgaJpZM4aK4Z0> .

[pandeagus]

[tttapa]

According to the Bias FX documentation, using just Control Change should work.

Did you manage to get the LEDs working?

[tttapa]

I have an exam tomorrow, so I can't really help you today.
Feel free to post any questions you have, but I won't be able to answer before tomorrow 17:00 CET.

[pandeagus]

Thank for the bias fx documentation.. I tried it using an example from the ProgramChanger from library but it didn't work. and i dont know why. can you give me clue ?

and for the LED i just try make new function code like this . its working but sometime little slow respons
for On LEd. and i dont why.. but its okay

void LEDswitch1 (){
int val1 = 0;
int ledOn1 = 0;
int pushed1 = 0;

val1 = digitalRead(switch1);

if (val1 == HIGH && ledOn1 == LOW){
pushed1 = 1-pushed1;
delay(5);
}
ledOn1 = val1;
if(pushed1 == HIGH){
Serial.println("led1 OFF");
digitalWrite(led1, LOW);
} else{
Serial.println("led1 ON");
digitalWrite(led1, HIGH);
}
delay(5);

}

[tttapa]

I don't know why the ProgramChanger doesn't work, last time I tested it, it worked, but I've made some changes after that, so I could have messed it up somehow. (The channel could be wrong, I think.)

Does the program changer show anything in MIDIOX? Did you connect the push buttons correctly (pins 5 & 6 via a push button to ground)?

I'll write you a better LED sketch tomorrow.

[tttapa]

466a0e9

[pandeagus]

hello brother i get error when try your example PushButtonsLEDsNoMIDIFeedback.ino.
how to solve?

[tttapa]

I'm sorry, I later added another commit where I used the standard library, which is not available on AVR, and I forgot to exclude it when compiling for AVR.

It should be fixed now: dd8e138

[pandeagus]

hello.. can you give me example using 74HC4051 multiplexer with 8 button
change MIDI CC and MIDI NOTE using your library.
im sorry i ask many thing to you.
thank you..

[tttapa]

Did you see the Getting Started page and the example that goes with it?

[pandeagus]

i get error when getting start using 8 button.. i just want make usb midi with multiplexer 4051 control
8 button can MIDI CC - MIDI NOTE together and 8 potentiometer and 8 led indicator switch..

im sorry bother you...
thanks

[tttapa]

Digital has been replaced by NoteButton. You cannot use the old MIDI Controller classe, they have been replaced by improved versions with a different name.

The documentation for all of these classes can be found here: https://tttapa.github.io/Control-Surface/Doc/Doxygen/d7/dcd/group__MIDIOutputElements.html

[tttapa]

If you really want to send both notes and CC at the same time (I still don't understand why it's necessary), you can instantiate a NoteButton and a CCButton on the same pin.

Alternatively, use this with the latest version of the library:

// Include the Control Surface library
#include <Control_Surface.h>

class DigitalNoteAndCCSender {
  public:
    static void sendOn(MIDICNChannelAddress address) {
      Control_Surface.MIDI().sendNoteOn(address, velocity);
      Control_Surface.MIDI().sendCC(address, onValue);

    }
    static void sendOff(MIDICNChannelAddress address) {
      Control_Surface.MIDI().sendNoteOff(address, velocity);
      Control_Surface.MIDI().sendCC(address, offValue);
    }
    constexpr static uint8_t velocity = 0x7F;
    constexpr static uint8_t onValue = 127;
    constexpr static uint8_t offValue = 0;
};

using NoteAndCCButton = MIDIButton<DigitalNoteAndCCSender::sendOn, 
                                   DigitalNoteAndCCSender::sendOff>;

// Instantiate a MIDI over USB interface.
USBMIDI_Interface midi;

using namespace MIDI_Notes;

// Instantiate the momentary push buttons that send out 
// MIDI Note and CC events.
NoteAndCCButton buttons[] = {
  {2, note(C, 4)}, // digital input pin, note number
  {3, note(Db, 4)},

  // If you want to set the channel specifically, you can use:
  // {2, {note(C, 4), CHANNEL_1}},
};

void setup() {
  // Initialize everything
  Control_Surface.begin();
}

void loop() {
  // Update the control surface
  Control_Surface.loop();
}

[pandeagus]

I am very lucky because you helped me in working on this project. and for that I thank you. and you are the best teacher in teaching me about midi controllers. and about MIDI CC and MIDI NOTE it's complete thanks to all your help. maybe later I will ask you more about the midi controller and I hope you don't get bored by answering my questions.

[tttapa]

No worries. Glad to hear you got it working!

[guillecip]

In the example of button with led once you push the button the led is always on.
Can we turn off the led in a toggle funcion? For example in Traktor if a turn on a FX a light in the screen turn on. When I turn off the FX the screen turn off. Can I do these with an external LED?

[masydoblig]

Like this one for cubase? YouTube link below https://youtu.be/sIzhsGYoD2U Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: guillecip <[email protected]> Sent: Wednesday, March 20, 2019 4:29:54 PM To: tttapa/Control-Surface Cc: Subscribed Subject: Re: [tttapa/Control-Surface] add led on/off while midi send note (#10) In the example of button with led once you push the button the led is always on. Can we turn off the led in a toggle funcion? For example in Traktor if a turn on a FX a light in the screen turn on. When I turn off the FX the screen turn off. Can I do these with an external LED? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#10 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Alaaoe34R3QgHqV7CbJAbiy6b29dEUOXks5vYcdSgaJpZM4aU4z7>.

[guillecip]

Yes, just like that.

[masydoblig]

Yes you can. Petes control surface library is pretty amazing. But to get the LEDs to come on when you activate a function the DAW needs to output a midi signal to your controller you have built. I have no experience with tractor but if it has mackie control it is completely possible. There is a full guide to this library and a link to it from the repository start page (In the description section at the bottom) There is also a non midi feedback button LED constructor in the examples I'm pretty sure. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: guillecip <[email protected]> Sent: Friday, March 22, 2019 1:45:19 AM To: tttapa/Control-Surface Cc: masydoblig; Comment Subject: Re: [tttapa/Control-Surface] add led on/off while midi send note (#10) Yes, just like that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#10 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AlaaocbZZLP4EXkp2lwNvKraqkDis9_Tks5vY5r_gaJpZM4aU4z7>.