Coder Social home page Coder Social logo

Changing theme crashes page about react HOT 7 CLOSED

tsparticles avatar tsparticles commented on May 3, 2024
Changing theme crashes page

from react.

Comments (7)

matteobruni avatar matteobruni commented on May 3, 2024 1

tsparticles/tsparticles#5071 this is the PR that will fix this issue

from react.

matteobruni avatar matteobruni commented on May 3, 2024 1

Updating the engine (2.12.0) should fix this.

from react.

brendon1555 avatar brendon1555 commented on May 3, 2024

I just noticed you have swapped out the deep equal package again since the last release. Apologies if I have jumped the gun on this issue if it will be solved with that change. If so, any ETA on a release including that?

from react.

matteobruni avatar matteobruni commented on May 3, 2024

I've tried changing that again, but it's not related to that. The code hangs at the setTimeout inside the play code of the Container class, without entering there.
I don't know why, since it's something that was already executed on the first load. It's something that I can't debug on the engine library since the code there works without issues.
I don't have an ETA about this, since it's a strange bug and I haven't figured out a way to search for similar issues.
I thought it was the compare library for the options changing, since there are recursive object that need to be ignored during the compare, but the component is never triggered by changes.

from react.

brendon1555 avatar brendon1555 commented on May 3, 2024

I attempted some debugging of my own and it appears to be getting into an infinite loop on the tsparticles Canvas mutationObserver here: https://github.com/matteobruni/tsparticles/blob/main/engine/src/Core/Canvas.ts#L82

I can look a bit deeper later on tonight and see if I get any further.

from react.

matteobruni avatar matteobruni commented on May 3, 2024

Thanks, that was enough for me. I didn't notice the infinite loop there. I don't understand why the MutationObserver object didn't disconnect correctly, but I've changed its management and now it resets at every refresh or stop/start cycle. A fix will be released soon.

from react.

brendon1555 avatar brendon1555 commented on May 3, 2024

Awesome! Glad I could help. Looking forward to the release.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.