Coder Social home page Coder Social logo

Comments (9)

Romakita avatar Romakita commented on June 24, 2024 1

Ho shit missed this issue. I'll try to find a way to fix that ASAP @VictoriqueMoe ;)

from tsed.

VictoriqueMoe avatar VictoriqueMoe commented on June 24, 2024

It seems to be coming from the validator badge

from tsed.

Romakita avatar Romakita commented on June 24, 2024

Hello @VictoriqueMoe

I finally decided to use the getAbsolutePath from swagger-ui-dist/get-absolute-path.js it seems to works correctly. I was thinking importing file directly (when exports isn't defined in the package.json of the module) doesn't works in ESM. Finally, if exports is missing, ESM can import any files in the package.

It should solve your issue ;)
See you

from tsed.

github-actions avatar github-actions commented on June 24, 2024

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

github opencollective

from tsed.

Romakita avatar Romakita commented on June 24, 2024

🎉 This issue has been resolved in version 7.68.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

from tsed.

VictoriqueMoe avatar VictoriqueMoe commented on June 24, 2024

Hello @VictoriqueMoe

I finally decided to use the getAbsolutePath from swagger-ui-dist/get-absolute-path.js it seems to works correctly. I was thinking importing file directly (when exports isn't defined in the package.json of the module) doesn't works in ESM. Finally, if exports is missing, ESM can import any files in the package.

It should solve your issue ;) See you

@Romakita

unfortantly, this did not solve the issue, i still get these 404's and the validator badge still errors
image
image

i deployed the latest tsed and you can see the error here: https://waifuvault.moe/api-docs/

from tsed.

Romakita avatar Romakita commented on June 24, 2024

Ok. But now the path is directly get from swagger-ui-dist. So it's not related to the latest changes. Maybe the problem is related to swagger-ui-dist itself?

from tsed.

Romakita avatar Romakita commented on June 24, 2024

But we can see a undefined string in the url. I'll check if other changes have introduce this regression. It's a bit complicated to repro in local when the badge is only displayed on a non localhost domain. I'll keep you informed if I found something ;)
And sorry for this unresolved issue!

from tsed.

VictoriqueMoe avatar VictoriqueMoe commented on June 24, 2024

But we can see a undefined string in the url. I'll check if other changes have introduce this regression. It's a bit complicated to repro in local when the badge is only displayed on a non localhost domain. I'll keep you informed if I found something ;) And sorry for this unresolved issue!

yeh, it's annoying for sure that is hard to test. editing the hosts file to proxy a localhost domain worked for me.

also, no problem! it's not really a blocker. However, this is a blocker: https://github.com/orgs/tsedio/discussions/2697 if that counts for anything :D

thank you as always for your amazing support and help

from tsed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.