Comments (12)
Depending when you want it done, you can assign this to me.
I'll be pretty busy till the 22nd, but after that it is full steam ahead.
from ghost.
Currently, scrolling the edit panel causes the preview panel to scroll at the same speed. However scrolling the preview panel does not scroll the edit panel.
Intentional!
A simple(ish) fix for this problem would be to scroll the two panels by the same percentage, rather than by the same distance. This should keep them more in sync, and at the very least they would both reach the end together.
That is exactly (to the letter) what is currently implemented.
A more complex fix would be to try to keep headings and other blocks aligned. Without investigating further the APIs provided by CodeMirror and showdown I'm not sure if or how this would be possible.
Agreed that would be better - also agreed that CodeMirror is not going to make this easy.
from ghost.
Currently, scrolling the edit panel causes the preview panel to scroll at the same speed. However scrolling the preview panel does not scroll the edit panel.
Intentional!
Ok, I raised this here because I've been using Ghost a lot (every wiki page and readme on GitHub was authored in Ghost) and I have found this to be a problem.
A simple(ish) fix for this problem would be to scroll the two panels by the same percentage, rather than by the same distance. This should keep them more in sync, and at the very least they would both reach the end together.
That is exactly (to the letter) what is currently implemented.
Odd.. it didn't seem to be happening for me. I need to review this and double check. However, if it is the case it's obviously not a great stop gap as it doesn't appear to work.
A more complex fix would be to try to keep headings and other blocks aligned. Without investigating further the APIs provided by CodeMirror and showdown I'm not sure if or how this would be possible.
Agreed that would be better - also agreed that CodeMirror is not going to make this easy.
Perhaps we should create an investigation task for this?
from ghost.
This has become massively laggy/horrible for me - I think due to #297? Why are we doing that?
(I've bumped this up to the 0.3 Milestone just to make sure we get it at least working in a basic way)
from ghost.
The debounce stops the 'advanced scrolling' from happening on every scroll event fired. This is probably the reason why it feels laggy. It should improve performance, so it is a case of finding the right amount of timing between each update so it stays visually smooth.
from ghost.
We might want to switch to throttle rather than debounce, have raised it as a bug as this issue is more to do with intelligent scrolling between the two panes.
from ghost.
It seems there were big improvements in codemirror4 in regarding to scrolling and layout perf, you might want to check it out:
https://groups.google.com/d/msg/codemirror/zQC6VQJuv20/IZXGi_Llv58J
from ghost.
@ErisDS This issue becomes irrelevant with planned new editor features. Suggest close
from ghost.
Closing as wontfix against #1294
from ghost.
Also, the preview panel scrolls the same amount, or to the same position as the edit panel. This appears to work well at first, but the content in the preview panel takes up different amounts of space, and in longer posts with lots of titles and code blocks the two panels quickly become out of sync visually.
Has this part of the issue been addressed?
from ghost.
@harpereaves no this was closed as a wontfix pending a different approach entirely
from ghost.
ah ok, thanks!
from ghost.
Related Issues (20)
- Integrations - FirstPromoter always showing as "active" HOT 2
- Admin API - Create Paid Members support HOT 1
- Node Version Requirement Not Declared Fine Enough HOT 4
- Wrong DNS records shown HOT 1
- Error updating to Ghost 5.80 from 5.23, blog down, please help HOT 1
- Comments broken in latest release HOT 5
- Internal tags not all displayed in admin panel
- Korean Romanization is Wrong HOT 3
- Ghost cannot connect to Mysql AWS RDS instance with latest CA from AWS HOT 2
- Handlebars special partial "@partial-block" gets reported as unknown global HOT 1
- Vulnerability Report: Regular Expression Denial of Service (ReDoS) in moment.js HOT 1
- Plain text view HOT 3
- Installation on Windows Fails with "A SystemError occurred." (nodejs version mismatch) HOT 1
- Newlines not correctly handled in product card titles
- Support Bluesky oEmbed auto-discovery HOT 4
- Editor tooltip for text styling is not visible when using android mobile
- Outdated version of string-width is causing the Docker image entrypoint loading to fail. HOT 2
- Site version in API not showing patch HOT 2
- glibc-vulnerability cve-2024-2961 [BUG] HOT 2
- Visitors on iOS prompted to download empty "auth-frame" file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghost.