Comments (7)
Thanks for opening up this issue. And wow good catch for #8 for denials! I'll fix that asap.
Regarding the original issue, I'm slightly inclined to continue the workflow of having multiple comments for additional context.
So you feel as though it would be better if this was a single comment?
denied.
Here is the reason that it was denied.
from manual-approval.
So you feel as though it would be better if this was a single comment?
denied. Here is the reason that it was denied.
Yes. The reasoning behind this would be that with the current implementation one would have to pre-write the approval/denial reason somewhere and then copy it into another comment after posting the approval/denial comment if one would want the reasoning to be available instantly. Which imo. can be important as people might be pretty fast in checking especially if something was denied so you would want the reason to be there too as soon as possible.
from manual-approval.
Good point. Maybe I should convert this into a slash command. So it would match on /deny
, /lgtm
, etc. What do you think? Would be easier to see "hey that's a command that will be handled" as opposed to just a normal string like current.
from manual-approval.
Hm, I kinda like the distinction but if anything I think that should be optional or configurable. (Or just apply to comments that have additional text) Otherwise I could imagine that such a change could break quite some people's workflows/lead to delays until the change actually reached everyone who's working with it.
from manual-approval.
Yeah I definitely can't break existing v1 users. I'd have to put the slash command behind a feature flag.
from manual-approval.
Reading this thread makes me think what if keywords for both approval and denial occur at the same time in the comment? Which one will take precedence?
from manual-approval.
Reading this thread makes me think what if keywords for both approval and denial occur at the same time in the comment? Which one will take precedence?
Shouldn't be an issue imo if only the first line is checked like in my original suggestion. Otherwise I would expect to eifher the first occurence to count or an error beign returned about ambigiousness.
from manual-approval.
Related Issues (20)
- Issue creation failing with 404 when using Team
- Documentation on "Org team approver" is misleading HOT 3
- Org Team Approver Documentation Issue HOT 2
- Add label to created issue
- Permission Denied at step start HOT 2
- increase log level
- Org team approver
- Request for release current main branch with issue-body HOT 1
- Argument list too long HOT 1
- [Feature request]: Allow codeowners file as approvers HOT 1
- Include a web UI link of the created issue in output so that readers can easily go to the issue in their browsers HOT 2
- Custom title for approval Issue.
- Issue body maximum is 65536 characters HOT 6
- Add individual members in a github team/org HOT 1
- Suspended User in a org team fails to create Issue in GHE HOT 1
- GitHub Issues can only have up to 10 people assigned to a issue HOT 1
- Pausing is very cost expensive HOT 8
- Option to set assignees as team
- [feature-request] Add an option to not fail if approvals are not met / timeout HOT 1
- 403 API rate limit of 60 still exceeded - no authentication?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manual-approval.