Comments (8)
We ran into this issue as well. Since hooks are tied into the lifecycle of a component. React doesn't like it if you exit the render function before all hooks are called.
function Foo () {
const query = useSomeQuery()
if (query.loading) return <Loading />
if (query.errors ) return <Errors />
// This will cause problems.
let [bar, setBar] = useState()
return <View bar={bar} setBar={setBar} data={query.data} />
}
Make sure all hooks are called before any early returns.
function Foo () {
let [bar, setBar] = useState()
const query = useSomeQuery()
if (query.loading) return <Loading />
if (query.errors ) return <Errors />
return <View bar={bar} setBar={setBar} data={query.data} />
}
from react-apollo-hooks.
@JClackett @rovansteen it seems it's an issue with React: facebook/react#14790
from react-apollo-hooks.
@JClackett could you please try to provide a reproduction on https://codesandbox.io?
from react-apollo-hooks.
@ncphillips Thanks! I checked and all my hooks are at the top of the function body above any returns 🤷♂️
@trojanowski I'm finding it hard to set up a codesandbox with a dummy graphql api, any suggestions?
One more thing i noticed is that when I am wrapping a component using memo() in a component, and using useQuery with suspend: true, that's when i get the errors, setting suspend: false removes all error.
function Child() {
const { data, error } = useQuery(GET_THING) // suspend: true
return (
<div>hello</div>
)
}
export default memo(Child)
and the parent
function Parent() {
return (
<Suspense fallback="loading...">
<Child />
</Suspense>
)
}
This gives the errors, however when setting suspend = false, then it's fine, am i missing something with memo/hooks/react-apollo-hooks?
from react-apollo-hooks.
I got similar errors, in my case, it was because I was lazy loading the component with the useQuery
hook with React.lazy. Looks like they don't play well together yet.
from react-apollo-hooks.
thanks @trojanowski, am happy to close this issue then, and wait on the react issue to be resolved
from react-apollo-hooks.
I have the same problem with React v16.8.3, the issue happens when I call useState
or useCallback
after calling useQuery
.
from react-apollo-hooks.
@foisonocean Could you please provide a reproduction on https://codesandbox.io? As a source you can use https://www.graphqlhub.com (GraphQL API url: https://www.graphqlhub.com/graphql, example query here).
from react-apollo-hooks.
Related Issues (20)
- Unable to Access Result Attributes
- Calling a mutation within React.useEffect causes infinite loop HOT 8
- Error on refetch
- Apollo client not handing Throw Error networkError eg.400,500
- data is no longer defined in 0.5.0 before data is loaded HOT 2
- Archive repo
- TypeError: Object(...) is not a function
- Question: How can I abort a query already in progress? HOT 1
- useLazyQuery ignores request if one is in progress (or how to cancel running requests)
- Support for `renderToStream`
- Correct network response but incorrect data object HOT 2
- Prevent infinite loop with useQuery
- Does useQuery hook uses local state for storing the data it receives from the server ?
- useSubscription - Duplicated subscription on page refresh HOT 1
- Refetching useQuery with skip: true results in a network request but does not update data
- Testing useSubscription and no responses when other mutations being mocked
- dynamic input variables in react-apollo-hooks
- Is it possible to map the result of one query to another query? HOT 1
- Is there any way to use multiple queries before a component render inside the component itself?
- UseQuery is not calling any API in the network side, when I console.log response, I am seeing this. what could be wrong here?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-apollo-hooks.