Comments (3)
Honestly, I don't think it's a good idea to allow the use of require
from tasks: what is the reason to do not require those modules in advance using wf-runner configuration?
Not to mention that we would be moving from "dangerous" to "completely unsafe" in terms of executing completely arbitrary code from vm
.
from node-workflow.
I would like to be able to reuse code and reduce boilerplate in my tasks. As far as security, I don't understand how this is any less safe. Your database and file system already hold 'arbitrary' code that is run anyway. We just don't have the option to require arbitrary files for our arbitrary code. Not sure how sandboxing in this case makes anything any safer. I don't understand where malicious injection would occur otherwise.
from node-workflow.
@TomKaltz allowing a task to use require
means that it could also require things like fs
and, for example, fork a child process, which could mess pretty much everything regarding how wf-runner work.
Anyway, I wouldn't be opposed to add a configurable option to use require
and have it disabled by default with that disclaimer you mentioned
from node-workflow.
Related Issues (20)
- node-gyp rebuild / dtrace-provider 0.2.8 fail under node 0.12.7 (osx 10.10.4) HOT 8
- backend.updateJobProperty VS _updateJobProperty (in combination with node-workflow-pg-backend)
- Gitter channel for discussion? HOT 2
- backend.updateWorkflow() strips chain and onerror function bodies HOT 2
- Task runner does not appear to handle retry of tasks consistently on timeout HOT 6
- feature request: pluggable task-runner
- Any way to do backend.addInfo from a task? HOT 3
- Task exception, not able to shut down runner HOT 1
- error when referencing same task in multiple chains of a workflow HOT 1
- is this been maintained? HOT 2
- node-workflow does not include the Error JavaScript builtin constructor in tasks' sandboxes HOT 1
- Storage of arbitrary job properties added during task execution HOT 5
- How to integrate with Meteor? HOT 1
- [ Question ] Multiple Runners Managing Job Queue
- Implement Joins
- package.json repository does not point to Joyent
- Add Buffer class and [set|clear]Immediate to wf-runner sandbox HOT 3
- node gyp rebuild for [email protected] fails with Node 8.11.3
- Is this still alive HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-workflow.