Comments (6)
Try adding the className prop of 'tripwire' while using the type of positive rather than primary. Example:
<Form.Button positive
className='tripwire'
type='submit'
disabled={!valid || submitting}
data-hook={generate-supervisor-button
}>Generate Supervisor</Form.Button>
from octagon.
We tried changing it, as suggested, but are still seeing differently rendered sizes.
<Flexbox>
<Form.Button
className='tripwire'
negative
data-hook={`cancel-generate-supervisor-button`}
onClick={this.handleClose}>Cancel
</Form.Button>
<Form.Button
className='tripwire'
positive
type='submit'
disabled={!valid || submitting}
data-hook={`generate-supervisor-button`}>Generate Supervisor</Form.Button>
</Flexbox>
from octagon.
That isn't applying the tripwire class to the actual button element. Can you call it following the styleguidist example? So it would be:
<Button
className='tripwire'
positive
type='submit'
disabled={!valid || submitting}
data-hook={generate-supervisor-button
}>Generate Supervisor
from octagon.
Yes, that worked! Thanks.
from octagon.
So is this a work around or an expected behavior? Seems odd to have to explicitly specify what I'd expect to just be the theme default.
from octagon.
Since the SUI button component has so many variations it doesn't seem like a good idea to change the default behavior, that's why we chose to implement it as a class that the developer can activate. This retains all of the default SUI button styling for future use if desired.
from octagon.
Related Issues (20)
- build doesn't verify commit mesages HOT 1
- An in-range update of react is breaking the build 🚨 HOT 3
- An in-range update of fs-extra is breaking the build 🚨 HOT 1
- An in-range update of semantic-release is breaking the build 🚨 HOT 9
- not all code conforms to standard
- An in-range update of react-styleguidist is breaking the build 🚨 HOT 3
- An in-range update of husky is breaking the build 🚨 HOT 3
- An in-range update of lint-staged is breaking the build 🚨 HOT 2
- suir prop-type warning on bell icon HOT 3
- handled prop passed thru as unhandled prop on NotifcationBody HOT 2
- An in-range update of npm-run-all is breaking the build 🚨 HOT 2
- variables.css isn't exported in build HOT 2
- SUIR dependency versions inconsistent / out of date HOT 1
- Enable branch protection on this repo HOT 3
- Add es module build
- Action required: Greenkeeper could not be activated 🚨 HOT 1
- Migrate gh-pages build to CircleCI 2.0
- Move moment to a optionalDependencies
- Switch from Moment to Luxon
- This repository is unmaintained
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octagon.