Coder Social home page Coder Social logo

button sizes about octagon HOT 6 CLOSED

tripwire avatar tripwire commented on August 12, 2024
button sizes

from octagon.

Comments (6)

eddier avatar eddier commented on August 12, 2024

Try adding the className prop of 'tripwire' while using the type of positive rather than primary. Example:

<Form.Button positive
className='tripwire'
type='submit'
disabled={!valid || submitting}
data-hook={generate-supervisor-button}>Generate Supervisor</Form.Button>

from octagon.

devongleeson avatar devongleeson commented on August 12, 2024

We tried changing it, as suggested, but are still seeing differently rendered sizes.

<Flexbox>
	<Form.Button
	  className='tripwire'
	  negative
	  data-hook={`cancel-generate-supervisor-button`}
	  onClick={this.handleClose}>Cancel
	</Form.Button>
	<Form.Button
	  className='tripwire'
	  positive
	  type='submit'
	  disabled={!valid || submitting}
	  data-hook={`generate-supervisor-button`}>Generate Supervisor</Form.Button>
</Flexbox>

image

from octagon.

eddier avatar eddier commented on August 12, 2024

That isn't applying the tripwire class to the actual button element. Can you call it following the styleguidist example? So it would be:

<Button
className='tripwire'
positive
type='submit'
disabled={!valid || submitting}
data-hook={generate-supervisor-button}>Generate Supervisor

from octagon.

devongleeson avatar devongleeson commented on August 12, 2024

Yes, that worked! Thanks.

from octagon.

ggascoigne avatar ggascoigne commented on August 12, 2024

So is this a work around or an expected behavior? Seems odd to have to explicitly specify what I'd expect to just be the theme default.

from octagon.

eddier avatar eddier commented on August 12, 2024

Since the SUI button component has so many variations it doesn't seem like a good idea to change the default behavior, that's why we chose to implement it as a class that the developer can activate. This retains all of the default SUI button styling for future use if desired.

from octagon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.