ElegantIcons module not found when importing semantic.css about octagon

[cdaringe]

there are some fonts in the tripwire theme... maybe those are them?

[cdaringe]

hmm, i thought i saw them before. guess not? xref: https://github.com/Tripwire/octagon/pull/18/files

[eddier]

When SUI is referencing the Elegant Icons its using the original location for those fonts which is /src/styles/fonts. Chris and I had talked about including the fonts as a package dependency however we haven't done that yet.

[jhegg]

Cool. I can't update the version of Octagon that I'm using until that happens. 😄

[eddier]

Its in progress now, I'll have it for you shortly.

[jhegg]

Thank you!

[jhegg]

When I use npm link, and try to use something like this in my project:

  <Icon className='ei' name='icon_error-triangle_alt' />

It doesn't find the ElegantIcon font and instead falls back to my default font, and also gives a warning of:

  Warning: Failed prop type: Invalid prop `name` of value `icon_error-triangle_alt` supplied to `Icon`.

If I reach across the linked module to import '../node_modules/react-octagon/src/styles/app.css', then the correct font is used (but I still get the invalid prop warning).

So, two questions:

1. Should the app.css be distributed somewhere under react-octagon/lib/*? Or rather, how should an application that is using react-octagon get the non-default styling/theme? I could just be using it wrong!
2. What can we do about the invalid prop value warning?

[eddier]

I'll start with the second issue - the prop name is validated against a predefined set of valid inputs held in an array. The recommended way around this is to use the className so in the example above it would be transformed as follows:

<Icon className='ei' name='icon_error-triangle_alt' />
to
<Icon className='ei icon_error-triangle_alt' />

There is a bit of a discussion on this here: Semantic-Org/Semantic-UI-React#931

[eddier]

For the first issue yes you probably want to update the builder.js to include a step for the /src/style dir. @cdaringe how do you want to handle this?

[cdaringe]

help me get caught up here. is the issue that the build process will need to manually move some font assets?

[eddier]

Yes the assets located in /src/styles are not available in the /lib dir after the build process is complete. The current build script handles components and sui, but not the style (fonts & css) objects.

[cdaringe]

closed by #25