Comments (13)
this would be toooo raaaad, storybookjs/storybook#602
from octagon.
Depending on the timeline for the above script we could use the doc-gen plugin to provide some the configuration options available to components. https://github.com/kadira-samples/react-storybook-docgen-info-sample
from octagon.
Alternatively is storybook providing any advantage compared to using Styleguidist exclusively?
from octagon.
@cdaringe this is an example of one of the existing custom components using the Styleguidist approach - if you want to check out how this might work in practice I can check this branch in.
from octagon.
hey @eddier, that looks saweeeet. very interested! lets try it youre down!
from octagon.
sorry for the lagged responses again, FYI. busy day!
from octagon.
It's on the styleguide branch, check it out and install dependencies then yarn run styleguide. Let me know what you think.
Still pretty experimental so let me know if you hit any issues!
from octagon.
it launched & ran great! lets discuss paths forward. i see a few options.
- no storybook, just styleguidist.
- this ostracizes UX, who is a first class customer & needs viz as the lib changes
- i.e. there isnt a "storybook-hub" tool for styleguidist to integrate them into the reviews easily
- this ostracizes UX, who is a first class customer & needs viz as the lib changes
- no styleguidist, just storybook
- lose out on interactivity & rich API docs
- those API docs are too good to lose!
- still could benefit from the component docs because of https://github.com/kadirahq/babel-plugin-react-docgen
- lose out on interactivity & rich API docs
- use both
- still get the benefits of both, but have a duplicate build temporarily to serve developers
im in favor of using both (option 3), with the intent to drop the standalone styleguidist in the high hopes that the storybook integration becomes a thingβ’.
thoughts? @Tripwire/octagonners @jhegg
from octagon.
@eddier , undefined
s are a little strange
$ yarn run styleguide
yarn run v0.21.0
$ styleguidist server
Style guide server started at:
http://localhost:3000
src/styles/components/pagination-control.css
undefined [undefined]
src/styles/components/favorite-button.css
undefined [undefined]
src/styles/app.css
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
Compiled successfully!
from octagon.
Yeah I figured we make a call on direction then we iron out any issues with the selected approach assuming it includes styleguidist.
from octagon.
im in favor of using both (option 3), with the intent to drop the standalone styleguidist in the high hopes that the storybook integration becomes a thingβ’.
That sounds like a good plan to me.
from octagon.
Sounds good. I've updated that branch with the following:
-
Section for custom components
- examples are automatically tracked as '.examples.md'
-
Section for SUI based components
- examples are tracked in the /styleguide/.examples.md'
- examples have to be manually entered which is probably ok given that there are not a ton and not all SUI components should be included in this, only extended ones.
from octagon.
merged!
from octagon.
Related Issues (20)
- build doesn't verify commit mesages HOT 1
- An in-range update of react is breaking the build π¨ HOT 3
- An in-range update of fs-extra is breaking the build π¨ HOT 1
- An in-range update of semantic-release is breaking the build π¨ HOT 9
- not all code conforms to standard
- An in-range update of react-styleguidist is breaking the build π¨ HOT 3
- An in-range update of husky is breaking the build π¨ HOT 3
- An in-range update of lint-staged is breaking the build π¨ HOT 2
- suir prop-type warning on bell icon HOT 3
- handled prop passed thru as unhandled prop on NotifcationBody HOT 2
- An in-range update of npm-run-all is breaking the build π¨ HOT 2
- variables.css isn't exported in build HOT 2
- SUIR dependency versions inconsistent / out of date HOT 1
- Enable branch protection on this repo HOT 3
- Add es module build
- Action required: Greenkeeper could not be activated π¨ HOT 1
- Migrate gh-pages build to CircleCI 2.0
- Move moment to a optionalDependencies
- Switch from Moment to Luxon
- This repository is unmaintained
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octagon.