Coder Social home page Coder Social logo

Comments (13)

cdaringe avatar cdaringe commented on August 12, 2024

this would be toooo raaaad, storybookjs/storybook#602

from octagon.

eddier avatar eddier commented on August 12, 2024

Depending on the timeline for the above script we could use the doc-gen plugin to provide some the configuration options available to components. https://github.com/kadira-samples/react-storybook-docgen-info-sample

from octagon.

eddier avatar eddier commented on August 12, 2024

Alternatively is storybook providing any advantage compared to using Styleguidist exclusively?

from octagon.

eddier avatar eddier commented on August 12, 2024

@cdaringe this is an example of one of the existing custom components using the Styleguidist approach - if you want to check out how this might work in practice I can check this branch in.

image

from octagon.

cdaringe avatar cdaringe commented on August 12, 2024

hey @eddier, that looks saweeeet. very interested! lets try it youre down!

from octagon.

cdaringe avatar cdaringe commented on August 12, 2024

sorry for the lagged responses again, FYI. busy day!

from octagon.

eddier avatar eddier commented on August 12, 2024

It's on the styleguide branch, check it out and install dependencies then yarn run styleguide. Let me know what you think.

Still pretty experimental so let me know if you hit any issues!

from octagon.

cdaringe avatar cdaringe commented on August 12, 2024

it launched & ran great! lets discuss paths forward. i see a few options.

  • no storybook, just styleguidist.
    • this ostracizes UX, who is a first class customer & needs viz as the lib changes
      • i.e. there isnt a "storybook-hub" tool for styleguidist to integrate them into the reviews easily
  • no styleguidist, just storybook
  • use both
    • still get the benefits of both, but have a duplicate build temporarily to serve developers

im in favor of using both (option 3), with the intent to drop the standalone styleguidist in the high hopes that the storybook integration becomes a thingβ„’.

thoughts? @Tripwire/octagonners @jhegg

from octagon.

cdaringe avatar cdaringe commented on August 12, 2024

@eddier , undefineds are a little strange

$ yarn run styleguide
yarn run v0.21.0
$ styleguidist server
Style guide server started at:
http://localhost:3000


src/styles/components/pagination-control.css
undefined [undefined]


src/styles/components/favorite-button.css
undefined [undefined]


src/styles/app.css
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]

Compiled successfully!

from octagon.

eddier avatar eddier commented on August 12, 2024

Yeah I figured we make a call on direction then we iron out any issues with the selected approach assuming it includes styleguidist.

from octagon.

jhegg avatar jhegg commented on August 12, 2024

im in favor of using both (option 3), with the intent to drop the standalone styleguidist in the high hopes that the storybook integration becomes a thingβ„’.

That sounds like a good plan to me.

from octagon.

eddier avatar eddier commented on August 12, 2024

Sounds good. I've updated that branch with the following:

  • Section for custom components

    • examples are automatically tracked as '.examples.md'
  • Section for SUI based components

    • examples are tracked in the /styleguide/.examples.md'
    • examples have to be manually entered which is probably ok given that there are not a ton and not all SUI components should be included in this, only extended ones.

from octagon.

cdaringe avatar cdaringe commented on August 12, 2024

merged!

from octagon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.