Comments (10)
I actually did that intentionally (for all packages) as I found it very annoying not to be able to see everything/reason of failing and than needed to restart the job with debug enabled.
We could probably improve this, any suggestions?
from nx-extend.
I see. Could we not just have it react on an environment variable, and then set that environment variable globally in the CI?
from nx-extend.
The reason is that right now, a simple pulumi preview contains 1400 lines of logs. 3 of those lines show me what pulumi intends to change. The rest is just noise, if that makes sense.
from nx-extend.
Because I'm lazy 😂, instead of needing to update multiple CI's I just added it here.
I can understand this would be annoying for Pulumi, if you want you can create a different const that does not contain the ci check and use that one for Pulumi.
from nx-extend.
Well, it's your project I suppose, and it was always intended for your needs. I respect that.
What do you mean different const?
And can you mention why it is you need verbose logging? Is it because you often find something wrong that needs the verbosity?
I'm also lazy, but that's also why I don't want to look through 1400 lines when I can look at 3. So that's why I am interested in the "why" of this, and understanding your perspective.
from nx-extend.
When deploying my Cloud Functions (@nx-extend/gcp-functions), Cloud Run (@nx-extend/gcp-cloud-run), Vercel (@nx-extend/vercel), Firebase (@nx-extend/firebase-hosting) or updating my secrets (@nx-extend/gcp-secrets) or even when running my tests (@nx-extend/e2e-runner), it they fail I would rather directly see what caused it instead of me having to rerun with debug mode on, especially in the CI as you need to pay for minutes but not log size.
Examples:
-
When running my e2e tests without debug mode the tests can fail, but did they fail because one of my API's was unable to start? I don't know, need to restart first.
-
When deploying anything in the CI (It are big projects so these things take time) and one of the deploys fails I want to see why and not restart with debug mode, wait another 10 minutes for the same error and than resolve it.
Note that all of these things logs a little extra, not like pulumi 1400 lines 😅
Regarding the const:
export const USE_VERBOSE_LOGGING = isCI() || Boolean(process.env.NX_VERBOSE_LOGGING)
We add (Better name suggestions welcome)
export const USE_VERBOSE_LOGGING_MINIMAL = Boolean(process.env.NX_VERBOSE_LOGGING || process.env. ACTIONS_RUNNER_DEBUG)
from nx-extend.
But if you're in doubt of whether it's because one of your APIs didn't start etc, shouldn't those messages be logged with higher verbosity?
And what I meant was that setting an environment variable globally for all jobs in a GitHub action work flow is quite easy.
As for the const, I guess that would work. As long as it doesn't do it for Pulumi, because that's really bad apparently 😅
from nx-extend.
As for the const, I guess that would work. As long as it doesn't do it for Pulumi, because that's really bad apparently 😅
I don't understand this one, could you elaborate a bit more? Making that constant will not work for Pulumi?
from nx-extend.
Ah yes that was indeed phrased weirdly. Yes, making a const would probably work for Pulumi. I think it's a good idea.
Unfortunately, I am a bit hung up on time right now. Is it possible for you to sneak this in?
from nx-extend.
Thanks!
from nx-extend.
Related Issues (20)
- [readCachedProjectGraph] ERROR: No cached ProjectGraph is available. HOT 3
- Nx v16, Cannot find module '@nrwl/cypress/src/executors/cypress/cypress.impl' HOT 1
- Pulumi: Running up with --yes or --skip-preview HOT 3
- Unmet peer dependency HOT 3
- Cannot find module '@nx/workspace/src/executors/run-commands/run-commands.impl' HOT 1
- Pulumi refresh support HOT 1
- Documentation for different packages HOT 1
- Getting routes undefined error in @nx-extend/strapi HOT 6
- Pulumi does not support importing things from libraries
- GCP Functions issue: Unknown package manager: [object Object]? HOT 2
- Getting error HOT 6
- Getting error when building strapi in NX HOT 8
- terraform module feature: pre-processing options HOT 2
- [readCachedProjectGraph] ERROR: No cached ProjectGraph is available. HOT 17
- Strapi: Error when building from workspace root HOT 5
- Terraform Destroy Command HOT 3
- Google Cloud functions framework not working when upgrading Nx from 17.0.3 -> 17.1.3 HOT 30
- Pulumi: Support for setting working directory HOT 8
- @nx-extend/e2e-runner doesn't kill devServerTarget on SIGINT HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nx-extend.