Why allow unlimited to edit allowance? about token-allowance-checker

[TripleSpeeder]

Hey, thank you for your feedback! The message you are seeing is actually quite misleading. What happens is the following:

1. TAC calls "approve" on the ERC20 token contract to change the approved amount for an existing spender address.
2. Metamask detects the "approve" call in the transaction and displays it's standard warning message, which is really useful for the normal usecase, but really confusing for the TAC usecase :-/

So in reality there is no approval done for TAC. Rather you are changing the approval for some other site. The problem is that Metamask can not know who is the owner of the spender address that TAC is changing the approval for, so they assume that the spender address belongs to the current website.

This question keeps coming up recently, so i raised an issue with Metamask to see if there is a way to improve the message, as it is really confusing. You can follow the issue at MetaMask/metamask-extension#9721.

I will also add a clarification to TAC why you see this warning. I fully agree with you that it sounds frightening.

[tennox]

More specific MetaMask issue:
MetaMask/metamask-extension#11125