python-trezor-0.7.13 crashes electrum-2.8.2 about python-trezor

[hegjon]

Environment: Fedora 25 x86-64, installed via RPM packages.

[prusnak]

This is a protobuf issue, not python-trezor.

See:

• tensorflow/tensorflow#57
• https://stackoverflow.com/questions/33622842/error-in-python-after-import-tensorflow-typeerror-init-got-an-unexpect
• etc.

[hegjon]

Thanks, I will look deeper into it

[hegjon]

Version 0.7.12 runs without any exceptions, while 0.7.13 causes this error. The protobuf-python version is the same. Could it be the way the generated protobuffer code is generated? Did you run with different versions of protobuf-compiler when running build_pb.sh?

[prusnak]

Ah, you might be on the right track. There was a commit (29348f4) between 0.7.12 and 0.7.13 where I regenerated protobufs and most probably python-protobuf version changed from 2.x to 3.x on my machine. Sorry for that :-/

Maybe we shoud bump the requirement for python-protobuf to 3.x series.

Would that be OK as a fix?

[hegjon]

That is fine, I am glad we have probably found the issue.

Fedora 25 ships with protobuf 2.5 as system package, but I have the option to run the protoc commands during the build. Will that cause problems? I probably need to create a package or bundle the protobuf messages.

[prusnak]

It probably should not cause problems if user does not mix trezor package from fedora with trezor package from pypi.