Comments (5)
What about defining a rule like "If it's not required, then the clear button should be visible when a selection is done"? If we set a select required with a default selection, then there will be no clear button and it will be not possible to make it invalid (like in pagination).
But I'm not sure about running the same rule on multi-selection mode. 🤔
from baklava.
We'll update the if as multiple or not required then.
I'll send a PR for this later today.
from baklava.
Looks like a nice suggestion. @buseselvi what do you think to show "clear selection button" to select, even if it's in single selection mode?
from baklava.
I think it is necessary to add the Clear button to the single select as well. But we need to keep it optional because, for the places like pagination, we bring the select selected and it should never be empty.
from baklava.
I looked at the benchmarks, and the clear button is always visible in multi-select, but it is optional in single-select.
from baklava.
Related Issues (20)
- [BUG]: Baklava select input popover close event trigger problem HOT 2
- trendyol.design Website HOT 1
- [BUG]: border-top is not coming correctly in BlInput label animation HOT 3
- Enhancing SSR Compatibility HOT 1
- npm install @trendyol/baklava
- Add Custom CSS Properties for Border Radius, Style, and Color to bl-button HOT 4
- Change table row hover color
- [BUG]: <Border of single select clear button is missing> HOT 1
- [Feature Request]: <Textarea Custom Validation>
- [BUG]: Empty bl-select causes floating-ui to throw an error HOT 2
- [BUG]: False positives for notification UI tests on PRs
- [BUG]: Searchable select hides label HOT 2
- [Feature Request]: Select search should support international character set
- [BUG]: Select search isn't cleared on option select
- [BUG]: Storybook select input triggers storybook shortcuts
- [Feature Request]: <Adding Critical Dialog Variant to Dialog Component>
- [Feature Request]: Create ADRs folder per component
- [Component]: <Spinner Component>
- [BUG]: <Split Button seperated events>
- [BUG]: Disabled select option can be selected with enter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baklava.