po2moz inserts extraneous comments closings into .dtd's about translate

[yurytch]

Created [attachment 28](http://bugs.locamotion.org/attachment.cgi?id=28)

3 dirs with 2 po’s , templates and outputs in each, respectively

[yurytch]

Yet worse case when the record is dropped after some complicated comment contents…

[yurytch]

Created [attachment 29](http://bugs.locamotion.org/attachment.cgi?id=29)

snippet of dtd demonstrating how credit.translation is dropped after moz2po

The testcase or the previous comment.

[davidfraser]

credit.translation being dropped was bug #15, and related to the emptiness of the
string rather than the comments. that is fixed in CVS and I have tested it comes
through properly.

[davidfraser]

I have added a test for the comment duplication to test_dtd.py, so this is
reproducible and should be fixed shortly

[davidfraser]

We were adding \n to the comment before stripping the comment from the line with
the result that if it had a trailing space, it came out as an unparsed line, and
so was repeated.
Doing the add after the stripping makes it work, this is now fixed in CVS and
the test passes (and your files seem to work) – can you verify when the next
snapshot is available / from CVS?

[davidfraser]

\ Bug #73 has been marked as a duplicate of this bug. *

[yurytch]

Well, with rc5.20051129 all my submitted examples work correctly… with some minor discrepancies,
however… Newlines are being re-distributed after cdonversion, differently in different examples. I
did both conversion from existing (formerly attached) example .po’s and also complete moz2po-po2
moz roundtrips.

So, I feel somewhat uneasy about it. I understand that this is tedious and ungrateful work, but
perhaps it’d be worth to iron this out now, while we are at it?..

In example #1 (msgFolderPickerOverlay.dtd) result is:
…
→<!- Labels —>
and the template dtd looks like:
…
—>

<— Labels —>

In example #2 (pref-notifications.dtd) everything is okay!

In example #3 (selectAddresses.dtd) output is:
…
- ****\* END LICENSE BLOCK ****\* →<!- Select addresses for mail message dialog —>

<!ENTITY…
and the template dtd is:
…
- ****\* END LICENSE BLOCK ****\* —>

<!ENTITY…

In example #4 (calendar.dtd) output is:
…>

<!ENTITY…
and template dtd is:
…>

<!ENTITY…

.

[davidfraser]

Thanks yury, I agree this shold be sorted out. Would you mind opening a fresh
bug with those comments? This bug is definitely fixed in terms of producing
invalid syntax…
I think it may be good to get 0.8 released first and then I want to totally redo
the dtd parsing and regeneration which should make it much simpler and cleaner