Coder Social home page Coder Social logo

Comments (8)

davidfraser avatar davidfraser commented on July 20, 2024

have a patch and about to test for this

from translate.

dwaynebailey avatar dwaynebailey commented on July 20, 2024

And here is another case. This time the label has no .label suffix:

#: certselect.auto
msgid "Select one automatically"
msgstr ""
#: certselect.auto.accesskey
msgid "e"
msgstr ""
#: certselect.ask
msgid "Ask me every time"
msgstr ""
#: certselect.ask.accesskey
msgid "k"
msgstr ""

As you can see they are valid access keys.

I woul drevise my advice to say match as follows:

  1. .label
  1. nothing
  1. .title

from translate.

dwaynebailey avatar dwaynebailey commented on July 20, 2024

And if that wasn’t enough now we have:

#: mapfileMenu.label
# Menu Items
# File menu
msgid "File"
msgstr ""
#: mapfilemenu.accesskey
msgid "f"
msgstr ""

Note that the accelerator entry is all in lowercase

from translate.

davidfraser avatar davidfraser commented on July 20, 2024

Oh dear. I have now committed a fix that supports .title
I wonder what we should do about the others.
There are periodic discussions about this in the mozilla l10n group.
The accelerator entry with the wrong case I would definitely class as a bug (I
can’t find it in firefox 1.5rc1)
The one with no title is slightly more tricky, I’ll have a think.
But see also for example this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=302006
where names where changed to ensure that accesskey and label match. So I think
we should have support for changing the actual entities

from translate.

davidfraser avatar davidfraser commented on July 20, 2024

Created [attachment 25](http://bugs.locamotion.org/attachment.cgi?id=25)

script that finds all accesskey combinations that don’t use simple .label and .accesskey

Wrote a script that finds all accesskeys in .dtd files that don’t have a simple
.label / .accesskey correspondence.
There are only 35 in total in Firefox 1.5, of these:
9 are a mismatch of names
7 are .title / .accesskey
5 share corresponding text in a single entity (port access keys in proxy
dialog)
5 are no suffix / .accesskey
4 are .label / .accessKey
4 seem to have no corresponding text in the file they’re defined in
1 is .button / .accesskey
Out of 567 accesskeys in the .dtd files in total, it seems like we’re taking
more effort to handle bad stuff than it would to fix the problems (and it would
fix it for other tools too like mozilla translator)

from translate.

davidfraser avatar davidfraser commented on July 20, 2024

Note that we also don’t yet do accesskey merging for properties files – there
are about 62 accesskeys in properties files.

from translate.

dwaynebailey avatar dwaynebailey commented on July 20, 2024

I think we are going about this the wrong way. Your script helps. I think we
should

  1. get .properties accesskeys working
  1. treat anomolies as bugs in Mozilla and file patches in Mozilla

from translate.

dwaynebailey avatar dwaynebailey commented on July 20, 2024

This Mozilla bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=329432

Is a meta bug for addressing accelerator and other problems in Thunderbird.

from translate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.