Comments (8)
have a patch and about to test for this
from translate.
And here is another case. This time the label has no .label suffix:
#: certselect.auto msgid "Select one automatically" msgstr "" #: certselect.auto.accesskey msgid "e" msgstr "" #: certselect.ask msgid "Ask me every time" msgstr "" #: certselect.ask.accesskey msgid "k" msgstr ""
As you can see they are valid access keys.
I woul drevise my advice to say match as follows:
- .label
- nothing
- .title
from translate.
And if that wasn’t enough now we have:
#: mapfileMenu.label # Menu Items # File menu msgid "File" msgstr "" #: mapfilemenu.accesskey msgid "f" msgstr ""
Note that the accelerator entry is all in lowercase
from translate.
Oh dear. I have now committed a fix that supports .title
I wonder what we should do about the others.
There are periodic discussions about this in the mozilla l10n group.
The accelerator entry with the wrong case I would definitely class as a bug (I
can’t find it in firefox 1.5rc1)
The one with no title is slightly more tricky, I’ll have a think.
But see also for example this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=302006
where names where changed to ensure that accesskey and label match. So I think
we should have support for changing the actual entities
from translate.
Created [attachment 25](http://bugs.locamotion.org/attachment.cgi?id=25)
script that finds all accesskey combinations that don’t use simple .label and .accesskey
Wrote a script that finds all accesskeys in .dtd files that don’t have a simple
.label / .accesskey correspondence.
There are only 35 in total in Firefox 1.5, of these:
9 are a mismatch of names
7 are .title / .accesskey
5 share corresponding text in a single entity (port access keys in proxy
dialog)
5 are no suffix / .accesskey
4 are .label / .accessKey
4 seem to have no corresponding text in the file they’re defined in
1 is .button / .accesskey
Out of 567 accesskeys in the .dtd files in total, it seems like we’re taking
more effort to handle bad stuff than it would to fix the problems (and it would
fix it for other tools too like mozilla translator)
from translate.
Note that we also don’t yet do accesskey merging for properties files – there
are about 62 accesskeys in properties files.
from translate.
I think we are going about this the wrong way. Your script helps. I think we
should
- get .properties accesskeys working
- treat anomolies as bugs in Mozilla and file patches in Mozilla
from translate.
This Mozilla bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=329432
Is a meta bug for addressing accelerator and other problems in Thunderbird.
from translate.
Related Issues (20)
- support several input parameters for pofilter (and other commands)
- Support for Android resource converter HOT 4
- prop2po: support for different encodings for both the input file and the template
- prop2po: personality given in command line is ignored for .strings files HOT 2
- Locate tests and test data outside 'translate' module HOT 2
- Ben
- Android: Some strings marked as `translatable="false"` still treated as translatable HOT 2
- Code block not parsed from Markdown HOT 3
- Proposal to use mdit-py-i18n (along with markdown-it-py) for Markdown support HOT 7
- Reduce question mark escaping in Android
- tests/translate/convert/test_rc2po.py failures with Python 3.12 HOT 7
- Translate
- Use Windows newlines for resx files
- Do not include "Explanation" field in iOS strings files HOT 2
- Add support for Mobile Kotlin resources HOT 3
- Locations for Markdown HOT 1
- Add support for Apple String Catalogs HOT 3
- Weird handling of C1 control characters in .properties files HOT 3
- Translate org app requests HOT 3
- Removing items during iteration can result in bugs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from translate.