Coder Social home page Coder Social logo

Comments (8)

jscanlannyc avatar jscanlannyc commented on June 8, 2024 1

Cool, that was helpful. I do have a PR ready that passed tests through this cmdline workflow:

python3 setup.py install; 
python3 -m unittest discover; 

I will issue the PR shortly.

from protofuzz.

jscanlannyc avatar jscanlannyc commented on June 8, 2024

Hi,

I am interested in fixing this issue. I have a few smaller questions before I write an implementation, as I do not want to annoy with a bad PR. I am flexible on all these answers, I see some of these as improvements, but I also know that keeping the change small is more manageable.

  1. Would it be OK if I replaced .format() with f-strings?
  2. Would it be OK if I used pathlib instead of strings for file location?
  3. While resolving the location fuzzdb dependency with importlib, would you like this to potentially be configurable as an env variable (os.environ)? This is in case someone installs this via pip or does not --recursively clone the project or has a separate fuzzdb instance they maintain.
  4. How do you feel about type annotations?

Please let me know. Thank you for your time.

from protofuzz.

woodruffw avatar woodruffw commented on June 8, 2024

Thanks for stating your interest!

  • Would it be OK if I replaced .format() with f-strings?
  • Would it be OK if I used Pathlib instead of strings for file location?

Yes, and yes! Please do these, any modernization would be greatly appreciated.

3. While resolving the location fuzzdb dependency with importlib, would you like this to potentially be configurable as an env variable (os.environ)? This is in case someone installs this via pip or does not --recursively clone the project or has a separate fuzzdb instance they maintain.

Sounds good to me. This is definitely a usability annoyance at the moment.

4. How do you feel about type annotations?

We love type annotations! Any you add here would also be greatly appreciated.

from protofuzz.

jscanlannyc avatar jscanlannyc commented on June 8, 2024

Thanks so much for the quick reply.

I have made my changes and would like to verify them against the test suite before issuing a PR. What is the suggested workflow for that? The nose website says it is in maintenance mode, should I use nose2? Something else?

from protofuzz.

woodruffw avatar woodruffw commented on June 8, 2024

Hmm, you shouldn't need either -- the tests under protofuzz/tests should be bog-standard unittest-based tests, meaning that the default built-in harness should work:

python -m unittest protofuzz.tests

(I think that's the right syntax.)

from protofuzz.

woodruffw avatar woodruffw commented on June 8, 2024

Whoops, this should work:

python -m unittest discover

from protofuzz.

woodruffw avatar woodruffw commented on June 8, 2024

Awesome! Feel free to give me a ping on it when you submit it.

from protofuzz.

woodruffw avatar woodruffw commented on June 8, 2024

#68.

from protofuzz.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.