validate :on currently not working about reform

[apotonick]

There is no concept like update or create in a form. Can you explain how you use this? I don't understand how you use a form in two different contexts. Could be a feature in the Reform::ActiveRecord extension...

[cj]

For example on a user form, when you have a new user form; you'll want to validate the presence of password_confirmation but you obviously wouldn't want that on an update.

[ivanyv]

How about NewUserForm and UpdateUserForm? I think that's what's intended with this library.

[apotonick]

@ivanyv That is absolutely right. However, if that makes it more convenient for people we should consider it.

[ivanyv]

Personally I like it as is. But here's a crazy idea: rename the save method to submit and move any automatic save functionality to a module to be included. Then submit calls a create or update method when that module is included, otherwise all it does is sync the params to the passed object.

Having the method called save kind of threw me off at first, but that might just be me :)

[fran-worley]

This has gone a little stale. I think that this is somewhat mitigated when a form is encapsulated within an operation.

If using dry-validations you could also build rules that only run if your form is persisted e.g.

def valid_field(value)
  return true if !form.persisted?  # the check passes

  value > 12 # if persisted then we check further
end

I'm going to close this, but please reopen if you need. 😄