Deprecation warning under Rails 2.3.11 and Cells 3.3.5 about cells

[apotonick]

Where's your fork where I can pull in that fix? ;-)

[luislavena]

Ha, I mostly don't fork when is a one liner, if not, I would have 300 projects instead of all the ones that I currently maintain.

Will send you a patch if that works.

[mattdb]

Sent a pull request that is backwards compatible with all versions of rails 2.3. Apologies, looks like the pull request also created a duplicate issue.

[apotonick]

Matt, thanks. Can you check if the current rails-2.3 branch works for you?

[apotonick]

Matt's fix is included in 3.3.6, thx.

[luislavena]

Thank you, this closed the issue but the new active_helper dependency introduced a double warning:

DEPRECATION WARNING: ActiveSupport::Dependencies.load_paths is deprecated, please use autoload_paths instead. (called from /Users/luis/.rvm/gems/ruby-1.8.7-p334/gems/active_helper-0.2.2/lib/active_helper/rails.rb:32)
DEPRECATION WARNING: ActiveSupport::Dependencies.load_paths is deprecated, please use autoload_paths instead. (called from /Users/luis/.rvm/gems/ruby-1.8.7-p334/gems/active_helper-0.2.2/lib/active_helper/rails.rb:32)

Reported as Issue 2 there:
apotonick/active_helper#2

[apotonick]

Luis, what "new active_helper dependency"???

[luislavena]

Cells 3.3.6 dependencies:
http://rubygems.org/gems/cells/versions/3.3.6

active_helper >= 0
rails ~> 2.3
shoulda >= 0

3.3.5 does not have those as dependencies:

http://rubygems.org/gems/cells/versions/3.3.5

Also I believe shoulda should be listed as development dependency and not runtime.

[apotonick]

Can you checkout the new gemspec version: http://rubygems.org/gems/cells/versions/3.3.7

[luislavena]

https://gist.github.com/1081553

I see a problem there, cells 3.3.7 depends on cells >= 0?

How are you generating the gemspec? I just checked rails-2.3 branch:

And neither cells.gemspec or Rakefile:

https://github.com/apotonick/cells/blob/rails-2.3/cells.gemspec
https://github.com/apotonick/cells/blob/rails-2.3/Rakefile

Shows the dependencies there.

[apotonick]

That seems to be a problem at rubygems' dependency algorithm, the cells.gemspec file is fine and runs :-) Can you verify?

[luislavena]

Well, I just cloned the repository, checkout rails-2.3 branch, installed jeweler, run rake gemspec and checked the generated gemspec, to my surprise:

  if s.respond_to? :specification_version then
    s.specification_version = 3

    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
      s.add_runtime_dependency(%q<cells>, [">= 0"])
      s.add_development_dependency(%q<shoulda>, [">= 0"])
      s.add_development_dependency(%q<active_helper>, [">= 0"])
    else
      s.add_dependency(%q<cells>, [">= 0"])
      s.add_dependency(%q<shoulda>, [">= 0"])
      s.add_dependency(%q<active_helper>, [">= 0"])
    end
  else
    s.add_dependency(%q<cells>, [">= 0"])
    s.add_dependency(%q<shoulda>, [">= 0"])
    s.add_dependency(%q<active_helper>, [">= 0"])
  end

That is what got pushed to rubygems.org, can you confirm that you see the same? cells >= 0 been listed as dependency. If you don't see it, I'm crazy.

[apotonick]

I removed jeweler in favor of a standard gemspec, look here: https://github.com/apotonick/cells/blob/1e4ec12f4f80d34f0cbf71feadb8738935b28aa2/cells.gemspec

Maybe the rake build command ran jeweler?

[luislavena]

If build task is provided by Jeweler gem, then it ran Jeweler and borked the gemspec.

I just run rake build on a pristine checkout and after closer inspection of the YAML metadata inside the generated gem seems that is modifying your dependencies.

However, doing a simple gem build cells.gemspec does generate a gem in the same directory that do not contain borked set of dependencies:

---
- !ruby/object:Gem::Dependency
  name: rails
  prerelease: false
  requirement: &id001 !ruby/object:Gem::Requirement
    none: false
    requirements:
    - - ~>
      - !ruby/object:Gem::Version
        hash: 5
        segments:
        - 2
        - 3
        version: "2.3"
  type: :runtime
  version_requirements: *id001
- !ruby/object:Gem::Dependency
  name: shoulda
  prerelease: false
  requirement: &id002 !ruby/object:Gem::Requirement
    none: false
    requirements:
    - - ">="
      - !ruby/object:Gem::Version
        hash: 3
        segments:
        - 0
        version: "0"
  type: :development
  version_requirements: *id002
- !ruby/object:Gem::Dependency
  name: active_helper
  prerelease: false
  requirement: &id003 !ruby/object:Gem::Requirement
    none: false
    requirements:
    - - ">="
      - !ruby/object:Gem::Version
        hash: 3
        segments:
        - 0
        version: "0"
  type: :development
  version_requirements: *id003

[apotonick]

3.3.8 works!

[luislavena]

@apotonick indeed, thank you!