Coder Social home page Coder Social logo

Comments (2)

SlicedSilver avatar SlicedSilver commented on June 24, 2024 1

Thanks for the bug report with the helpful example.

I think it makes more sense if the library automatically refreshes the chart when a primitive is removed instead of relying on the Plugin code to do this within the detached lifecycle hook. So while it would be possible to fix this within the plugins code (in this case plugin-base), it would make more sense to implement this by adding this._series.model().fullUpdate(); to the end of detachPrimitive method.

public detachPrimitive(primitive: ISeriesPrimitive<HorzScaleItem>): void {
this._series.detachPrimitive(primitive as ISeriesPrimitiveBase<unknown>);
if (primitive.detached) {
primitive.detached();
}
}

from lightweight-charts.

Rafael-Ramblas avatar Rafael-Ramblas commented on June 24, 2024 1

I found one more information about this. This issue only happens for line charts, other types of charts works as expected without having the need to call the requestUpdate method, and adding the line suggested actually causes a runtime error.

from lightweight-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.