Coder Social home page Coder Social logo

Comments (4)

Infinity0106 avatar Infinity0106 commented on June 17, 2024

Don't you think the code is too short to create multiple files?, I didn't know that you could import html

from react-native-highcharts.

mmazzarolo avatar mmazzarolo commented on June 17, 2024

I don't think so, especially if it is a library which might grow in the future (but it also is a matter of personal preference, of course :) )
The code linting and styiling though should be required for PRs in my opinion, so that you can avoid issues like #14 but whatever.
Just my 2 cents, I opened an issue instead of a PR because I'm aware that it's also a matter of taste!

from react-native-highcharts.

jonrh avatar jonrh commented on June 17, 2024

I agree that this project is now at a stage where we should maybe start thinking about an agreed upon linting procedure. I hear prettier 💅 is all the rage these days 💪. Should we perhaps create a separate issue for it?

from react-native-highcharts.

mmazzarolo avatar mmazzarolo commented on June 17, 2024

I can't praise Prettier higly enough, it simply rocks!

from react-native-highcharts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.