isVisible() -> element.offsetTop -> proposal of replacement about ng-defer-load

[vinayakpatil]

var elementOffset = this._element.nativeElement.getBoundingClientRect().top + (window.scrollY || window.pageYOffset); works for me in IE

[VamsiVempati]

Hi @peterpeterparker & @vinayakpatil

Very sorry, somehow seem to have missed this!

The changes suggested seem reasonable, however I'm unable to test this atm.

@mzoellner might be a bit closer to this repo now than I am, what are your thoughts @mzoellner ?

Thank you,
Vamsi Vempati

[peterpeterparker]

Thx for the feedback @VamsiVempati

Actually I don't use this library anymore, therefore, when it comes to me, we can simply close this feature request.

[mzoellner]

Hi @vinayakpatil,
sorry for the delay here.
We are not very active with reviewing PRs for this package.
I am trying to fit it in during the next couple of days and get back to you.

[mzoellner]

Hi @vinayakpatil,
I did the regression test on our end and it looks all good.
Once you have updated the PR, I will merge it in.

[asgerjensen]

I dont know... doesn't getBoundingClientRect() cause a full relayout calculation in some browsers?

[vinayakpatil]

Hi @VamsiVempati , can you please check #37 and share your thoughts?

[vinayakpatil]

HI @VamsiVempati just following up on this one, thanks!

[vinayakpatil]

@mzoellner did you get a chance to review this? Thanks

[mzoellner]

I dont know... doesn't getBoundingClientRect() cause a full relayout calculation in some browsers?

According to https://gist.github.com/paulirish/5d52fb081b3570c81e3a this._element.nativeElement.offsetTop; also does, so it probably does not matter.

[vinayakpatil]

Hi @mzoellner, did you get a chance to check this? Thanks

[mzoellner]

Hi @vinayakpatil,
really sorry this is taking so long.
Could you please update your PR, so the merge conflicts are resolved ?

I will merge it in, once I have confirmed that the calculation is correct and we won't have any regression on our end.