Can't build cppcodec about cppcodec

[jpetso]

Thanks. I believe this is fixed by pull request #55, which depends on Catch >= 2.3.0 and includes changed to test_cppcodec.cpp. I'll close this issue once #55 gets merged, if you want to verify it then please let me know if it works for you after the patch.

[CleanHit]

If i'm not wrong then the fedora 28 repositories only have the catch catch-devel-2.2.2 and catch1-devel-1.12.1 packages at the moment. Since I don't use the test functionality for now, I've done this:

#if (BUILD_TESTING)
#    add_subdirectory(test)
#endif()

To avoid the error with make.

[jpetso]

Yep, that works too. cppcodec includes a copy of Catch, so if the system version isn't found (Catch 2.3.0 provides a different pkg-config version) then it uses the included version instead. After the patch from my PR, assuming git submodules are updated, it should work without patch even when your system only provides 2.2.

[jpetso]

Should be fixed with commit 302dc28 from PR #55. If the same problems persist, please reopen the bug. Thanks!