Comments (3)
I just tried exactly the above repro steps and I wasn't able to repro.
Clans API has two GetAsync methods:
Task<SearchResult> GetAsync(QueryClans query);
Task<Clan> GetAsync(string clanTag);
The latter one (GetAsync(string clanTag)
) is the one where you provide a clan tag and it gives the clan information. The former one (GetAsync(QueryClans query)
) is where you provide a QueryClans object that has properties to filter the search results. If QueryClans is provided empty in API call then Supercell API returns a bad request to caller with next information:
Content: {"reason":"badRequest","message":"At least one filtering parameter must exist"}
That is a valid error because QueryClans must always have at least one filtering criteria defined.
If you could share a sample solution with this problem that I can just open in VS and get into the state, it would be great for investigating.
from clashofclans.
Thank you for your reply. Attached is an example project which causes the exception when run.
from clashofclans.
Thanks for providing the project to investigate this more. I found the issue causing this behavior. It seems that net461 does not URL encode hash (#) character automatically whereas netcoreapp2.2 implementation of HttpClient will do it.
I changed the implementation of the library to URL encode hash character always and now it seems to work properly also in net461. I will push a commit soon to fix this issue and release 3.0.5 version of the NuGet package with the fix.
Thanks for reporting this issue!
from clashofclans.
Related Issues (20)
- Add support for capital league APIs
- "ClanCapital" village missing in enum HOT 2
- ConfigureAwait usage inside the library
- Add a validator for LabelIds
- Split test project for unit tests and integration tests
- Refactor DocFX files to own folder
- Improve the paging usage
- Support multiple tokens via ClashOfClansClient API
- Improve test method names
- Implement a support for C# 8.0 Nullable Reference Types (NRT)
- Unnecessary nullable value types
- Improvement: Start to Use Dependency Injection
- Improve the usage of appsettings.json
- Implement a basic functionality for Discord
- Improve NuGet package by adding a README.md HOT 2
- Heads up! The branch 'main' that you pushed to was renamed to 'main1'. HOT 1
- Change the logging to use ILogger
- Use .NET 6 for building
- Add support for clan capital
- Add support for new API: Retrieve clan's capital raid seasons
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clashofclans.