PackedNode type need modifications. about tox

[kpp]

I don't like the distance to depend on the status of the node

[NamsooCho]

Node having possibility of offline should be replaced with higher priority.
Also, c-toxcore uses this concept of Good and Bad nodes.
When we get new nodes from NodesResponse, we have to select node which will be replaced.

[kurnevsky]

I suggest not to touch PackedNode struct but create new DhtNode struct (or similar name) because PackedNode is used in packets and should be serialized/deserialized as is. And then we can create functions to convert PackedNode to DhtNode.

[kurnevsky]

Node having possibility of offline should be replaced with higher priority.

But we can compare nodes outside of distance function, just check status first. distance is used not only for DHT and shouldn't be dependent on node status.

[kpp]

DhtNode is a good suggestion

[NamsooCho]

Then I will create DhtNode type, and replace_order() function.
replace_order() will compare status of node and PK's distance.
replace_order() will be used in Kbucket and Bucket.
So, Bucket struct will changed from

struct Bucket {
    nodes: Vec<PackedNode>
    ...
}

to

struct Bucket {
    nodes: Vec<DhtNode>
    ....
}

[kpp]

let's try

[kurnevsky]

Then we can merge ClientData with DhtNode.