using with and providing a timeout about filelock

[AdorablePotato]

At the moment, there is no other way. Would a fix of issue #2 help you?

There would still be the problem with providing a timeout value in the with statement. I don't want to change the behavior of the acquire method for backward compatibility, but I could implement the __call__ method to allow you doing this:

with self.lock(timeout = 10):

I'm open for any ideas.

[AdorablePotato]

I noticed now, that I broke the API with the reference counter, since your example worked before.

[benprew]

I think the __call__ method idea sounds good, my python skills aren't great, so you probably have better ideas than I do :)

[AdorablePotato]

I fixed this issue in the dev branch. You can now use the acquire() method also in the with statement without side effects. So this works now:

with lock.acquire(timeout = 10):
  assert lock.is_locked
  with lock.acquire(timeout = 10):
    assert lock.is_locked
assert (not lock.is_locked)

I will upload the new version in the next days.

[benprew]

Awesome, thanks for making the change so quickly!

On Thu, May 28, 2015 at 3:54 PM Benedikt Schmitt [email protected]
wrote:

I fixed this issue in the dev branch. You can no use the acquire()
method also in the with statement without side effects. So this works now:

with lock.acquire(timeout = 10):
assert lock.is_locked
with lock.acquire(timeout = 10):
assert lock.is_lockedassert (not lock.is_locked)

I will upload the new version in the next days.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.