Proper Arc support for schematic and footprint about jlc2kicad_lib

[TousstNicolas]

Seems to be working flawlessly. Good job.

However, I think it might not be required to redefined the wheel by creating a new vector2D class. Most methods are already available with the vector2D class from KicadModTree :

• all __ __ methods already exists
• length is .distance_to((0,0))
• perpendicularClockwise is .rotate(90)
• perpendicularCounterClockwise is .rotate(-90)

from that, rewritten the concern part without the need to create a new class :

        # find the midpoint of start and end
        mid = [(start[0] + end[0]) / 2, (start[1] + end[1]) / 2]
        # create vector from start to mid:
        vec1 = Vector2D(mid[0] - start[0], mid[1] - start[1])
        # create vector that's normal to vec1:

        length_squared = pow(midX, 2) - pow(vec1.distance_to((0,0)), 2)
        if length_squared < 0:
            length_squared = 0
            reversed = "1"

        if reversed == "1":
            vec2 = vec1.rotate(-90)
            magnitude = sqrt(vec2[0]**2 + vec2[1]**2)
            vec2 = Vector2D(vec2[0]/magnitude, vec2[1]/magnitude)
        else:
            vec2 = vec1.rotate(90)
            magnitude = sqrt(vec2[0]**2 + vec2[1]**2)
            vec2 = Vector2D(vec2[0]/magnitude, vec2[1]/magnitude)

        # calculate the lenght from mid to centre using pythagoras:
        length = sqrt(length_squared)
        # calculate the centre using mid and vec2 with the correct length:
        cen = Vector2D(mid) + vec2 * length

        cen_start = cen - start
        cen_end = cen - end

        # calculate angle between cen_start and cen_end
        dot_product = cen_start.x*cen_end.x + cen_start.y*cen_end.y
        angle = acos(dot_product / (cen_start.distance_to((0,0)) * cen_end.distance_to((0,0))))

Can you create a PR with just the commit you made for this issue ? It will help to keep track of the different issues and their according corrections.

[TousstNicolas]

Thanks a lot for your work, merged in 12c6860

[Xyntexx]

I made my version of the code and it seems to be working pretty well so far:
https://github.com/Xyntexx/JLC2KiCad_lib/tree/my_ARC_Fixes