Coder Social home page Coder Social logo

Comments (14)

enebo avatar enebo commented on August 22, 2024 1

@mkristian I already talked to @cshupp1 on irc he definitely wants to test on 9.1.13.0 branch. Testing on master would be nice too but it should be the same commit which fixed cherry-picked over.

from jruby9-maven-plugins.

mkristian avatar mkristian commented on August 22, 2024

just answered the same on the jruby list:

I would need the output from mvn -X ... . the only place I could find this generate_dir_info is inside the de.saumya.mojo.gem.ProcessResourcesMojo - do you use this plugin in your pom.xml ?

from jruby9-maven-plugins.

cshupp1 avatar cshupp1 commented on August 22, 2024

I sent a response to the JRuby mailing list. Thanks for your help. I included the POM and the output of two

mvn -X clean package

Where the pom file has either:

		<dependency>
			<groupId>org.jruby</groupId>
			<artifactId>jruby-complete</artifactId>
			<version>9.1.8.0</version>
		</dependency>

or

	       <dependency>
			<groupId>org.jruby</groupId>
			<artifactId>jruby-complete</artifactId>
			<version>9.1.12.0</version>
		</dependency>

Thanks,

Cris

from jruby9-maven-plugins.

mkristian avatar mkristian commented on August 22, 2024

@cshupp1 can not see the output of mvn clean package -X on the mailing list (this emails kind of fall through my net as well). could you just create a gist and link the gist here or so.

from jruby9-maven-plugins.

cshupp1 avatar cshupp1 commented on August 22, 2024

https://gist.github.com/cshupp1/15743b5cbeed99739e160a6ebf08a301

Thanks,

Cris

from jruby9-maven-plugins.

mkristian avatar mkristian commented on August 22, 2024

@headius any idea why jruby-9.1.12.0 can parse this command line string:


The ' characters around the executable and arguments are
--
  | not part of the command.
  | [INFO] Setting environment variable: JARS_SKIP=true
  | [INFO] Setting environment variable: GEM_PATH=C:\work\va-ctt\rails\rails_komet\target\rubygems
  | [INFO] Setting environment variable: GEM_HOME=C:\work\va-ctt\rails\rails_komet\target\rubygems
  | [INFO] Setting environment variable: JBUNDLE_SKIP=true
  | [INFO] Execute:Java13CommandLauncher: Executing 'C:\languages\Java\jdk1.8.0_121\jre\bin\java.exe' with arguments:
  | '-cp'
  | 'C:\Users\cshupp\.m2\repository\org\jruby\jruby-complete\9.1.12.0\jruby-complete-9.1.12.0.jar'
  | '-Xmx4000m'
  | '-Djava.awt.headless=true'
  | '-Xbootclasspath/a:C:\Users\cshupp\.m2\repository\org\jruby\jruby-complete\9.1.12.0\jruby-complete-9.1.12.0.jar'
  | 'org.jruby.Main'
  | '-I'
  | 'C:\work\va-ctt\rails\rails_komet\lib'
  | '-e'
  | 'require 'jruby/commands'; JRuby::Commands.generate_dir_info 'C:\work\va-ctt\rails\rails_komet\target\rubygems' if JRuby::Commands.respond_to? :generate_dir_info'
  | '--'
  |  
  | The ' characters around the executable and arguments are
  | not part of the command.
  | [INFO] Unhandled Java exception: java.lang.NullPointerException
  | [INFO] java.lang.NullPointerException: null
  | [INFO]        getBytes at java/lang/String.java:940
  | [INFO]          <init> at org/jruby/ast/SymbolNode.java:54
  | [INFO]        asSymbol at org/jruby/parser/ParserSupport.java:975
  | [INFO]         execute at org/jruby/parser/RubyParser.java:4286
  | [INFO]         yyparse at org/jruby/parser/RubyParser.java:1677
  | [INFO]         yyparse at org/jruby/parser/RubyParser.java:1568
  | [INFO]           parse at org/jruby/parser/RubyParser.java:5365
  | [INFO]           parse at org/jruby/parser/Parser.java:128
  | [INFO]           parse at org/jruby/parser/Parser.java:105
  | [INFO]     parseInline at org/jruby/Ruby.java:2685
  | [INFO]   parseFromMain at org/jruby/Ruby.java:608
  | [INFO]     runFromMain at org/jruby/Ruby.java:556
  | [INFO]   doRunFromMain at org/jruby/Main.java:417
  | [INFO]     internalRun at org/jruby/Main.java:305
  | [INFO]             run at org/jruby/Main.java:232
  | [INFO]            main at org/jruby/Main.java:204


seems to be related to this commit: jruby/jruby@01cd84d46de

from jruby9-maven-plugins.

mkristian avatar mkristian commented on August 22, 2024

@headius the encoding.getCharset() can be null if I understand the jcoding.Encoding code right. not sure what the fallback could be. but once the fallback charset is clear the patch is trivial.

from jruby9-maven-plugins.

enebo avatar enebo commented on August 22, 2024

@mkristian the -e part of this seems fixed now so I am guessing this is resolvable now.

@cshupp1 can you verify this is ok with jruby-9.1.13.0 branch? ci.jruby.org should have a nightly too if you don't routinely build JRuby.

from jruby9-maven-plugins.

cshupp1 avatar cshupp1 commented on August 22, 2024

@enebo, @mkristian It will take me 2-3 days to get to it, but I will. Thank you so much for your help with this.

from jruby9-maven-plugins.

cshupp1 avatar cshupp1 commented on August 22, 2024

@enebo, @mkristian There is no 9.1.13. Is JRuby jumping to 9.2?
What do I put here to get the correct snapshot?

org.jruby jruby-complete 9.1.12.0

from jruby9-maven-plugins.

cshupp1 avatar cshupp1 commented on August 22, 2024

@enebo , @mkristian
Sorry, what do I put here?

	       <dependency>
			<groupId>org.jruby</groupId>
			<artifactId>jruby-complete</artifactId>
			<version>9.1.12.0</version>
		</dependency>

from jruby9-maven-plugins.

mkristian avatar mkristian commented on August 22, 2024

@cshupp1 you need to use <version>9.2.0.0-SNAPSHOT</version> and build jruby from source with ./mvnw -Pcomplete

from jruby9-maven-plugins.

cshupp1 avatar cshupp1 commented on August 22, 2024

Guys,
@enebo and @mkristian
This all started with this defect:
jruby/jruby#4669

and I am pleased to say that after cloning and building 9.1.13 and testing my build against the snapshot my build worked for both of my projects! I also loaded the war into tomcat and tested one of the react component's JavaScript and it worked!

Thanks for the help!

Cris

[INFO] React On Rails: Symlinking "jsTree/40px-e42d2daab8bdb92822d13842e91f4a4c7b96fac75c8fb986fae9c0f46a67431e.png" to "jsTree/40px.png"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-13634da87d9e23f8c3ed9108ce1724d183a39ad072e73e1b3d8cbf646d2d0407.eot" to "bootstrap/glyphicons-halflings-regular.eot"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-13634da87d9e23f8c3ed9108ce1724d183a39ad072e73e1b3d8cbf646d2d0407.eot.gz" to "bootstrap/glyphicons-halflings-regular.eot.gz"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-fe185d11a49676890d47bb783312a0cda5a44c4039214094e7957b4c040ef11c.woff2" to "bootstrap/glyphicons-halflings-regular.woff2"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-a26394f7ede100ca118eff2eda08596275a9839b959c226e15439557a5a80742.woff" to "bootstrap/glyphicons-halflings-regular.woff"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-e395044093757d82afcb138957d06a1ea9361bdcf0b442d06a18a8051af57456.ttf" to "bootstrap/glyphicons-halflings-regular.ttf"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-e395044093757d82afcb138957d06a1ea9361bdcf0b442d06a18a8051af57456.ttf.gz" to "bootstrap/glyphicons-halflings-regular.ttf.gz"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-42f60659d265c1a3c30f9fa42abcbb56bd4a53af4d83d316d6dd7a36903c43e5.svg" to "bootstrap/glyphicons-halflings-regular.svg"
[INFO] React On Rails: Symlinking "bootstrap/glyphicons-halflings-regular-42f60659d265c1a3c30f9fa42abcbb56bd4a53af4d83d316d6dd7a36903c43e5.svg.gz" to "bootstrap/glyphicons-halflings-regular.svg.gz"
[INFO] "build the context file"
[INFO] "build the version file"
[INFO] ** Invoke war (first_time)
[INFO] ** Execute war
[INFO] ** Invoke war:files (first_time)
[INFO] ** Execute war:files
[INFO] ** Invoke war:jar (first_time)
[INFO] ** Execute war:jar
[INFO] rm -f ./target//rails_prisme.war
[INFO] Creating ./target//rails_prisme.war
[INFO]
[INFO] --- build-helper-maven-plugin:3.0.0:attach-artifact (attach-artifacts) @ rails_prisme ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10:16 min
[INFO] Finished at: 2017-08-30T12:54:06-04:00
[INFO] Final Memory: 17M/123M
[INFO] ------------------------------------------------------------------------

from jruby9-maven-plugins.

mkristian avatar mkristian commented on August 22, 2024

@cshupp1 great news. FYI I will release a new version of these maven plugins once jruby-9.1.13 is released and after some work on the mavengem libraries. closing this issue.

from jruby9-maven-plugins.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.