[$60] TaaS Teams return not all resources. about taas-apis

[maxceem]

I've got why to filter there. It's because we use this code for getting a list of projects, not only for getting one project.

We can think what would be a good fix there.

[nkumar-topcoder]

@maxceem good catch, we need to discuss

[maxceem]

So the issue here is because we are calling searchResourceBookings(criteria) which returns 20 results per page by default. As we calling this method without specifying the project id, we are getting more resources for all the projects, which is more than 20. But as we get only the 1st page, we get some random set of resources.

First of all, this method should support filtering by multiple project ids, so we can get resources only for some projects which we are showing on the main page of taas app, not all projects as we do now.

The second task is to get all of the resources for the selected projects, not only 20.

We could set some big perPage value when calling searchResourceBookings(criteria), but potentially we may want to limit the maximum perPage in our API, which would break it again.

So instead of increasing perPage which can get broken, we may add some extra argument for searchResourceBookings(criteria) like internallyReturnAll searchResourceBookings(criteria, internallyReturnAll). Which would force the method to return all the records and ignoring perPage (don't set it for requests from ES and DB).

[maxceem]

@imcaizheng feel free to pick this up if you like.

If you have any better ideas on how to fix this issue, please let me know.

[imcaizheng]

@maxceem How about directly querying DB for resources instead of invoking searchResourceBookings(criteria)? I think it is more common to retrieve data internally inside a service.

[maxceem]

Thanks, @imcaizheng, I forgot to consider such an option. Though it also has its disadvantage - we would mix data from ES and from DB. I'm not sure if it could lead to real issues and data inconsistency, but it feels like not the right thing to do. Also, I've noticed that in the TaaS API we always get data from ES so far (with DB fallback). The same I can see in Challenge API https://github.com/topcoder-platform/challenge-api/blob/develop/src/services/ChallengeService.js#L18-L20.

So let's adapt the method searchResourceBookings which gets data from ES, so we can reuse it for our needs.

[imcaizheng]

@maxceem Agreed.

[imcaizheng]

PR created #56

[maxceem]

Contest https://www.topcoder.com/challenges/30158247 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

Contest https://www.topcoder.com/challenges/30158247 has been updated - it has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

[maxceem]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30158247

This is an automated message for maxceem via Topcoder X