Comments (8)
@sdgun ,
For deleting bio
, it should be fixed in this PR: #27
For skills
, since there is no event published when skills got updated, we only check the skills flag if there is another profile or profile trait update
So, if you update skills, you need to update any of profile picture
, bio
, education
work
or language
after it to fire an event to be processed by our processor
@vikasrohit , @veshu
I do not have write access to this repository. So, I cannot add Ready for Review
label to fixed issues
from onboarding-processor.
@sdgun please log the skill deletion issue as separate issue now to track it better. As this seems to be a fairly rare use case, we can handle it after the release.
from onboarding-processor.
Created #31
from onboarding-processor.
@veshu ,
- On which branch should the work be done feature/profile-completeness ?
- Do you want a PR for each issue ? or a single PR for all issues
cc @vikasrohit
from onboarding-processor.
@Schpotsky separate PR for each issue would be better, but if single PR makes your life easy, go ahead with that as well. It is not strict yet.
For branch please use develop branch for base work. You can create PR against develop as well as it is not feature now.
from onboarding-processor.
Thanks @Schpotsky for the quick turnaround. skills
is something we can not do much here without an event, agreed.
from onboarding-processor.
@Schpotsky When delete all existing skills and make an update to any other setting(bio, education etc), the skills flag is still true in the response.
from onboarding-processor.
Verified in production.
from onboarding-processor.
Related Issues (18)
- Have a feature to disable ID verification
- Traits API returns profile_picture: false even if Profile picture is uploaded HOT 6
- Implement onboarding trait for Payment method setup HOT 1
- Implement onboarding trait for ID Verification step HOT 1
- Implement onboarding trait for profile completeness
- Remove title field for now from the profile completeness check HOT 4
- Add address to the profile completeness onboarding step check HOT 12
- Validate the fields for the profile completeness when any other field is updated HOT 17
- None of the profile updates are returned in the response for new user HOT 4
- Update Tax Form Receiver to generate v5 bus events for docusign document completion events HOT 3
- When delete skills and make an update settings, the skills flag is still true in the response. HOT 3
- Remove strict validation from legacyId for terms event payload HOT 5
- Store the date as timestamp for id_verification onboarding step HOT 7
- Onboarding trait save fails because ES consistency in member api HOT 1
- Update processor to handle the docusign events generated by terms-receiver HOT 4
- Welcome message flips from handle to name HOT 2
- Create traits for standard and nda terms sign
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onboarding-processor.