Coder Social home page Coder Social logo

Would a verify_if make sense? about assertr HOT 4 CLOSED

dpprdan avatar dpprdan commented on August 17, 2024
Would a verify_if make sense?

from assertr.

Comments (4)

tonyfischetti avatar tonyfischetti commented on August 17, 2024

In the hypothetical code in the last line of your comment, it would just check cyl for each column that is numeric.
If there were a function for that, it couldn't be a form of verify. verify is more flexible than the other assertions and doesn't have to work on data.frames at all. Is assert not ok for this use case?

is_int <- function(x) x == floor(x)

df %>% assert(is_int, cyl, vs:carb)

or

df %>% assert_(is_int, names(df)[sapply(df, is.numeric)])

from assertr.

dpprdan avatar dpprdan commented on August 17, 2024

My hypothetical code is nonsense of course since it wasn't my intention to just check cyl, but all numeric columns in the data_frame (of which I ideally do not want to provide the names).

So my use-case would be to check if all numeric columns (which are currently e.g. stored as double) are really all integers before converting them to integers. And all that without providing the column names.

The column name part disqualifies your first solution. Your second solution is fine. It just does not completely adhere to the tidyverse (or magrittr pipe) conventions of not having to specify the data_frame several times, I guess. So what about:

df %>% assert_if(is.numeric, is_int)

But really,

df %>% assert_(is_int, names(df)[sapply(df, is.numeric)])

is fine!

from assertr.

tonyfischetti avatar tonyfischetti commented on August 17, 2024

Here are some other alternatives!

df %>% assert_(., is_int, names(.)[sapply(., is.numeric)])

and

df %>% select_if(., is.numeric) %>% assert(is_int, everything())

By careful with the last one, though–it'll make data the new smaller data frame with only numeric columns.

I consider this good enough for now because we're working on some other cool features. I'll reinvestigate potentially adding *_if functions afterwards. Is it ok with you if I close this issue for now?

from assertr.

dpprdan avatar dpprdan commented on August 17, 2024

Of course, this certainly isn't mission-critical.
Thanks for considering it!

from assertr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.