Comments (4)
still precompile other ES6 features to ES5 if it intends to support older browsers
@gaearon curious about your thoughts here. ES2015 has been well supported across browsers for years, so I'm not terribly inclined to translate our builds to ES5. The operative word in your docs is if, but I'm not sure if there's an alternative when a package doesn't support ES5 (other than to fork, as you mention later in those docs).
from midi.
I just looked at the module
line, and it's pointing directly to our src
folder, which makes me even less inclined to touch it.
from midi.
Hello @appsforartists
Would you like me to open the issue over at the React repository?
from midi.
If you want to, sure. It would be the create-react-app repo, and I don't know what they'd do. As I understand it, CRA is supposed to be a zero-config starter, which means there isn't a place to add exceptions.
But, requiring all dependencies to be ES5 seems heavyhanded, especially if you're importing from ES2015 modules. At the very least, I think they ought to fall back to main
if module
isn't ES5. (I'm still not convinced it makes any sense for them to require ES5 dependencies, but I don't know enough about that project to make a definitive statement.)
from midi.
Related Issues (20)
- endOfTrackTicks set in json is not set in midi file HOT 1
- Read/Write midi with lyrics loses text events HOT 2
- error TS2305: Module 'midi-file' has no exported member 'MidiTrackData' HOT 1
- How can I execute a function when the MIDI file has ended? HOT 1
- no "PPQ" key in midi header in node.js HOT 3
- Cannot use ES6 import syntax in node HOT 1
- Converto Json to Midi HOT 2
- I am not able to add silences in a track HOT 2
- Changing note name in original midi
- Downloading midi file without Node HOT 2
- Encoding key signatur with wrong mapping of major & minor scales HOT 1
- Notes with Velocity of 0 is not always equivalent to Note off HOT 2
- Microtones HOT 1
- duration is calculated incorrectly...do not use end of last note to calculate duration of clip... HOT 1
- Adding control changes does not work
- Add a option to parse midi tracks without spliting It by channel / instrument
- Ability to edit `track.instrument` info (read-only for now)
- Timeout on midi.header.ticksToSeconds, when using a midi made by MuseScore. midi.tracks[0].endOfTrackTicks undefined. HOT 1
- NPM package outdated, causing MIDI lyric parsing issue
- Convert Midi into JSON HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from midi.